Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated tsconfig to match current node version #956

Open
mrgrain opened this issue May 10, 2024 · 0 comments
Open

Update generated tsconfig to match current node version #956

mrgrain opened this issue May 10, 2024 · 0 comments
Labels
enhancement New feature or request p2

Comments

@mrgrain
Copy link
Contributor

mrgrain commented May 10, 2024

jsii 5.3+ only supports Node 18+ (and has been for a while).

We should match the default tsconfig (lib, target, module) to match the recommended settings from the TypeScript project
https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-18

(jsii 5.2 supports Node16, so this should not be backported or we should use the older settings)

We can only change these in new minor versions, otherwise it's breaking (particularly module).

@mrgrain mrgrain added the p2 label Jun 11, 2024
@mrgrain mrgrain changed the title Update tsconfig to match current node version Update generated tsconfig to match current node version Aug 21, 2024
@mrgrain mrgrain added the enhancement New feature or request label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p2
Projects
None yet
Development

No branches or pull requests

1 participant