Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smithy-go data race in latest release of aws-sdk-go-v2 #2907

Open
3 tasks done
abraithwaite opened this issue Nov 22, 2024 · 0 comments
Open
3 tasks done

smithy-go data race in latest release of aws-sdk-go-v2 #2907

abraithwaite opened this issue Nov 22, 2024 · 0 comments
Labels
bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@abraithwaite
Copy link

Acknowledgements

Describe the bug

This bug in a dependency is present in the latest release, and triggers with the race detector on:

aws/smithy-go#548

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

I expect no race to happen in the library or it's dependencies.

Current Behavior

When running code with the race detector enabled, it trips and triggers the race.

Reproduction Steps

	cfg, err := config.LoadDefaultConfig(context.TODO())
	if err != nil {
		return err
	}
	s3client := s3.NewFromConfig(cfg)
	uploader := manager.NewUploader(s3client, func(u *manager.Uploader) {
		u.Concurrency = 5
		u.LeavePartsOnError = false
	})

	_, err := uploader.Upload(ctx, &s3.PutObjectInput{
		Bucket: aws.String(bucket),
		Key:    aws.String(key),
		Body:   in.Data,
	})
	return err

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

$ grep 'aws-sdk-go-v2' go.mod
        github.com/aws/aws-sdk-go-v2 v1.32.5
        github.com/aws/aws-sdk-go-v2/config v1.28.5
        github.com/aws/aws-sdk-go-v2/credentials v1.17.46
        github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.39
        github.com/aws/aws-sdk-go-v2/service/s3 v1.67.1
        github.com/aws/aws-sdk-go-v2/service/sts v1.33.1
        github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.7 // indirect
        github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.20 // indirect
        github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.24 // indirect
        github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.24 // indirect
        github.com/aws/aws-sdk-go-v2/internal/ini v1.8.1 // indirect
        github.com/aws/aws-sdk-go-v2/internal/v4a v1.3.24 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.12.1 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/checksum v1.4.5 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.12.5 // indirect
        github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.18.5 // indirect
        github.com/aws/aws-sdk-go-v2/service/sso v1.24.6 // indirect
        github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.5 // indirect

Compiler and Version used

go version go1.23.3 darwin/arm64

Operating System and version

Darwin root.us-west-2.local 23.6.0 Darwin Kernel Version 23.6.0: Thu Sep 12 23:36:12 PDT 2024; root:xnu-10063.141.1.701.1~1/RELEASE_ARM64_T6020 arm64

@abraithwaite abraithwaite added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2024
@github-actions github-actions bot added the potential-regression Marking this issue as a potential regression to be checked by team member label Nov 22, 2024
@lucix-aws lucix-aws added p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. potential-regression Marking this issue as a potential regression to be checked by team member labels Nov 22, 2024
@RanVaknin RanVaknin assigned RanVaknin and unassigned RanVaknin Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

3 participants