Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithy NullAndEmptyHeaders protocol tests will be ignored until they are published by Smithy #2825

Closed
2 of 3 tasks
Madrigal opened this issue Oct 7, 2024 · 2 comments
Closed
2 of 3 tasks
Assignees
Labels
bug This issue is a bug. queued This issues is on the AWS team's backlog

Comments

@Madrigal
Copy link
Contributor

Madrigal commented Oct 7, 2024

Acknowledgements

Describe the bug

Smithy has updated their protocol tests to allow non-nil empty headers in smithy-lang/smithy#2403
However, these updated tests haven't been released as of Smithy 1.51.0.

When we push a fix for the issue, we need to temporarily skip these tests until they are fixed

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

All protocol tests should pass ideally, but these are expected to be broken until they are published

Current Behavior

These protocol tests fail, but it's expected until Smithy publishes the new version

Reproduction Steps

make unit

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

n/a

Compiler and Version used

n/a

Operating System and version

n/a

@Madrigal Madrigal added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 7, 2024
@Madrigal Madrigal self-assigned this Oct 7, 2024
@lucix-aws lucix-aws added queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2024
@Madrigal
Copy link
Contributor Author

Madrigal commented Nov 4, 2024

Closed by #2881

@Madrigal Madrigal closed this as completed Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

2 participants