Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of which files to exclude during CustomMakeBuilder:CopySource #3350

Closed
komapa opened this issue Oct 8, 2021 · 5 comments
Labels

Comments

@komapa
Copy link

komapa commented Oct 8, 2021

Describe your idea/feature/enhancement

Related to some of what I said in #3348

If your source tree has a lot of files, think golang vendor/ folder AND also node_modules, CustomMakeBuilder:CopySource is super slow to the point of not even completing in many minutes (not sure if just the way it copies is also inefficient?) The root folder was close to 500MB, so not a lot of storage but I guess a lot of files.

Proposal

It will be great if you can support reading .gitignore or allow for a .samignore file that will allow us to exclude large directories which are not needed for building but are naturally in the repo because of the project structure you might have in place.

Additional Details

Thank you!

@qingchm qingchm added area/build sam build command type/feature Feature request labels Oct 8, 2021
@qingchm
Copy link
Contributor

qingchm commented Oct 12, 2021

Also thanks for this ticket! We will be pulling it in for internal discussion!

@nthornton2010
Copy link

Yes please! My makefile being in the root causes sam build to take over 10 minutes to complete just because of node_modules.

@ksmoore17
Copy link

Would be a solution for #1755 and #2310 -> examples of this being caused by python's venv and node_modules and occurring for pip builder and npm builder

@torresxb1
Copy link
Contributor

We have a few issues asking for a similar thing in ignore: or a .samignore file. Closing so that we can track here: aws/aws-lambda-builders#185

@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants