From 28ff1e91f24854e598dc1ce0d005fabb639105c9 Mon Sep 17 00:00:00 2001 From: Arun Karthik Date: Sun, 6 Oct 2024 08:55:00 +0000 Subject: [PATCH] fix : Fix flexible array member allocation Corrected allocation of `nccl_net_ofi_schedule_t` to account for flexible array member. The previous implementation did not allocate enough memory for the flexible array `xfer_info` elements, leading to potential out-of-bounds access. --- tests/unit/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/scheduler.c b/tests/unit/scheduler.c index 04d034f0d..d66901fa1 100644 --- a/tests/unit/scheduler.c +++ b/tests/unit/scheduler.c @@ -59,7 +59,7 @@ int verify_schedule(nccl_net_ofi_schedule_t *schedule, nccl_net_ofi_schedule_t * int create_ref_schedule(nccl_net_ofi_schedule_t **schedule, int num_xfer_infos) { int ret = 0; - *schedule = (nccl_net_ofi_schedule_t *)malloc(sizeof(nccl_net_ofi_xfer_info_t) + + *schedule = (nccl_net_ofi_schedule_t *)malloc(sizeof(nccl_net_ofi_schedule_t) + num_xfer_infos * sizeof(nccl_net_ofi_xfer_info_t)); if (!(*schedule)) {