From c23814d3e429477e79f84b7ed8f23fc9faa60205 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 11:27:25 -0700 Subject: [PATCH 01/22] Added release workflow --- .github/workflows/release.yml | 57 +++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 .github/workflows/release.yml diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml new file mode 100644 index 0000000..22ea159 --- /dev/null +++ b/.github/workflows/release.yml @@ -0,0 +1,57 @@ +name: Release +on: + workflow_dispatch: + inputs: + releaseVersion: + description: "Version to use for the release." + required: true + default: "X.Y.Z" + developmentVersion: + description: "Version to use for further development" + required: true + default: "X.Y.Z-RIE" +jobs: + release: + environment: release + runs-on: ubuntu-latest + steps: + # - uses: actions/checkout@v3 #in SnapStart but moved to below + - name: Configure Git User # may be removed after https://github.com/actions/checkout/issues/13 is resolved + uses: actions/checkout@v3 + run: | + git config user.email "${{ github.actor }}@users.noreply.github.com" + git config user.name "${{ github.actor }}" + - name: Checkout + uses: actions/checkout@v4 + - name: Build + run: make compile-with-docker-all + # run: echo ${{ github.sha }} > Release.txt + # - name: Test + # run: cat Release.txt + - name: Release + uses: softprops/action-gh-release@v2 + if: startsWith(github.ref, 'refs/tags/') + with: + files: | + aws-lambda-rie + aws-lambda-rie-arm64 + aws-lambda-rie-x64 +# -------- + # Add a step to upload each binary asset + # - name: Upload aws-lambda-rie + # uses: actions/upload-artifact@v2 + # with: + # name: aws-lambda-rie + # path: /path/to/aws-lambda-rie + + # - name: Upload aws-lambda-rie-arm64 + # uses: actions/upload-artifact@v2 + # with: + # name: aws-lambda-rie-arm64 + # path: /path/to/aws-lambda-rie-arm64 + + # - name: Upload aws-lambda-rie-x64 + # uses: actions/upload-artifact@v2 + # with: + # name: aws-lambda-rie-x64 + # path: /path/to/aws-lambda-rie-x64 From 2bb1aaa5ee9fdbb66827df643b309df1b335afa7 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 11:57:46 -0700 Subject: [PATCH 02/22] Fix release workflow --- .github/workflows/release.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 22ea159..dc45b5a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,4 +1,5 @@ name: Release + on: workflow_dispatch: inputs: @@ -10,19 +11,23 @@ on: description: "Version to use for further development" required: true default: "X.Y.Z-RIE" + jobs: - release: - environment: release + Release: + environment: Release runs-on: ubuntu-latest steps: - # - uses: actions/checkout@v3 #in SnapStart but moved to below + - uses: actions/checkout@v3 - name: Configure Git User # may be removed after https://github.com/actions/checkout/issues/13 is resolved - uses: actions/checkout@v3 run: | git config user.email "${{ github.actor }}@users.noreply.github.com" git config user.name "${{ github.actor }}" - - name: Checkout - uses: actions/checkout@v4 + # - name: Checkout + # uses: actions/checkout@v4 + - name: Set up python + - uses: actions/setup-python@v5 + with: + python-version: '3.11' - name: Build run: make compile-with-docker-all # run: echo ${{ github.sha }} > Release.txt From fec8e2eba296ec4551bf8a28f317c16aaa6ce911 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 11:58:40 -0700 Subject: [PATCH 03/22] Fix release workflow --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index dc45b5a..0254d25 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -26,8 +26,8 @@ jobs: # uses: actions/checkout@v4 - name: Set up python - uses: actions/setup-python@v5 - with: - python-version: '3.11' + with: + python-version: '3.11' - name: Build run: make compile-with-docker-all # run: echo ${{ github.sha }} > Release.txt From a37cfbd1af4a6dd15b3480491c0609a95368391a Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 12:03:46 -0700 Subject: [PATCH 04/22] Fix release workflow --- .github/workflows/release.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0254d25..5aa62ad 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,9 +30,6 @@ jobs: python-version: '3.11' - name: Build run: make compile-with-docker-all - # run: echo ${{ github.sha }} > Release.txt - # - name: Test - # run: cat Release.txt - name: Release uses: softprops/action-gh-release@v2 if: startsWith(github.ref, 'refs/tags/') From 297a40023480016493c63a09ed2f09cae9e916a4 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 12:05:00 -0700 Subject: [PATCH 05/22] Fix release workflow --- .github/workflows/release.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5aa62ad..0be7a34 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -29,9 +29,10 @@ jobs: with: python-version: '3.11' - name: Build + - uses: actions/checkout@v4 run: make compile-with-docker-all - name: Release - uses: softprops/action-gh-release@v2 + - uses: softprops/action-gh-release@v2 if: startsWith(github.ref, 'refs/tags/') with: files: | From 28b5fd3a412ec286ab400be0a93defd3ecbd12a5 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 12:07:37 -0700 Subject: [PATCH 06/22] Fix release workflow --- .github/workflows/release.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0be7a34..a3ccdea 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,22 +17,20 @@ jobs: environment: Release runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - name: Configure Git User # may be removed after https://github.com/actions/checkout/issues/13 is resolved + uses: actions/checkout@v3 run: | git config user.email "${{ github.actor }}@users.noreply.github.com" git config user.name "${{ github.actor }}" - # - name: Checkout - # uses: actions/checkout@v4 - name: Set up python - - uses: actions/setup-python@v5 + uses: actions/setup-python@v5 with: python-version: '3.11' - name: Build - - uses: actions/checkout@v4 + uses: actions/checkout@v4 run: make compile-with-docker-all - name: Release - - uses: softprops/action-gh-release@v2 + uses: softprops/action-gh-release@v2 if: startsWith(github.ref, 'refs/tags/') with: files: | From c81bba2e98904c7c090204174d6d81343480f6fd Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 1 May 2024 12:08:43 -0700 Subject: [PATCH 07/22] Fix release workflow --- .github/workflows/release.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a3ccdea..fe23bb3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,8 +17,8 @@ jobs: environment: Release runs-on: ubuntu-latest steps: + - uses: actions/checkout@v3 - name: Configure Git User # may be removed after https://github.com/actions/checkout/issues/13 is resolved - uses: actions/checkout@v3 run: | git config user.email "${{ github.actor }}@users.noreply.github.com" git config user.name "${{ github.actor }}" @@ -27,7 +27,6 @@ jobs: with: python-version: '3.11' - name: Build - uses: actions/checkout@v4 run: make compile-with-docker-all - name: Release uses: softprops/action-gh-release@v2 From c7087d41395ebdb23bcfbeefac87ee4382661db2 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 8 May 2024 15:32:17 -0700 Subject: [PATCH 08/22] Fixing release --- .github/workflows/release.yml | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fe23bb3..516ea4a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -11,13 +11,12 @@ on: description: "Version to use for further development" required: true default: "X.Y.Z-RIE" - jobs: Release: environment: Release runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Configure Git User # may be removed after https://github.com/actions/checkout/issues/13 is resolved run: | git config user.email "${{ github.actor }}@users.noreply.github.com" @@ -27,15 +26,15 @@ jobs: with: python-version: '3.11' - name: Build - run: make compile-with-docker-all + run: make compile-with-docker-all #they are all in is bin/aws-lambda-rie* - name: Release - uses: softprops/action-gh-release@v2 - if: startsWith(github.ref, 'refs/tags/') + uses: softprops/action-gh-release@v2 # this triggers release if the assets are tagged with refs/tags + # if: startsWith(github.ref, 'refs/tags/') with: files: | - aws-lambda-rie - aws-lambda-rie-arm64 - aws-lambda-rie-x64 + bin/aws-lambda-rie + bin/aws-lambda-rie-arm64 + bin/aws-lambda-rie-x64 # -------- # Add a step to upload each binary asset # - name: Upload aws-lambda-rie From b6a1f98069412dbea03daa21d91dedc44186a8af Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 8 May 2024 15:38:09 -0700 Subject: [PATCH 09/22] adding tag name --- .github/workflows/release.yml | 23 ++--------------------- 1 file changed, 2 insertions(+), 21 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 516ea4a..c102d25 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -28,29 +28,10 @@ jobs: - name: Build run: make compile-with-docker-all #they are all in is bin/aws-lambda-rie* - name: Release - uses: softprops/action-gh-release@v2 # this triggers release if the assets are tagged with refs/tags - # if: startsWith(github.ref, 'refs/tags/') + uses: softprops/action-gh-release@v2 with: + tag_name: tag_nameee files: | bin/aws-lambda-rie bin/aws-lambda-rie-arm64 bin/aws-lambda-rie-x64 -# -------- - # Add a step to upload each binary asset - # - name: Upload aws-lambda-rie - # uses: actions/upload-artifact@v2 - # with: - # name: aws-lambda-rie - # path: /path/to/aws-lambda-rie - - # - name: Upload aws-lambda-rie-arm64 - # uses: actions/upload-artifact@v2 - # with: - # name: aws-lambda-rie-arm64 - # path: /path/to/aws-lambda-rie-arm64 - - # - name: Upload aws-lambda-rie-x64 - # uses: actions/upload-artifact@v2 - # with: - # name: aws-lambda-rie-x64 - # path: /path/to/aws-lambda-rie-x64 From 693332c6fe84dde14ab3270ae297b959176fd6f6 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 8 May 2024 15:42:18 -0700 Subject: [PATCH 10/22] Edit tag name --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c102d25..e700266 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,8 +30,8 @@ jobs: - name: Release uses: softprops/action-gh-release@v2 with: - tag_name: tag_nameee + tag_name: "v*.*.*" files: | bin/aws-lambda-rie bin/aws-lambda-rie-arm64 - bin/aws-lambda-rie-x64 + bin/aws-lambda-rie-x86_64 From 16ebddf879ba6050b0c6019ea7d0ef9e955558c6 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 8 May 2024 15:45:53 -0700 Subject: [PATCH 11/22] Editing tag --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e700266..44a4f80 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -30,7 +30,7 @@ jobs: - name: Release uses: softprops/action-gh-release@v2 with: - tag_name: "v*.*.*" + tag_name: ${{ github.event.inputs.releaseVersion }} files: | bin/aws-lambda-rie bin/aws-lambda-rie-arm64 From 483638678ec55c04b75c99cf2db85aeaae614e56 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Wed, 8 May 2024 15:49:50 -0700 Subject: [PATCH 12/22] Clean up comments --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 44a4f80..5816f81 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -26,7 +26,7 @@ jobs: with: python-version: '3.11' - name: Build - run: make compile-with-docker-all #they are all in is bin/aws-lambda-rie* + run: make compile-with-docker-all - name: Release uses: softprops/action-gh-release@v2 with: From f1f9b2068efa2d5bcafc5e9f98ccc73dc8cea9c4 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 10:12:45 -0700 Subject: [PATCH 13/22] comment revisions --- .github/workflows/release.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5816f81..ae09818 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -7,30 +7,31 @@ on: description: "Version to use for the release." required: true default: "X.Y.Z" - developmentVersion: - description: "Version to use for further development" - required: true - default: "X.Y.Z-RIE" + # developmentVersion: #this could be the release notes?? + # description: "Version to use for further development" + # required: true + # default: "X.Y.Z-RIE" jobs: Release: environment: Release runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - name: Configure Git User # may be removed after https://github.com/actions/checkout/issues/13 is resolved - run: | - git config user.email "${{ github.actor }}@users.noreply.github.com" - git config user.name "${{ github.actor }}" + with: + ref: 'main' - name: Set up python uses: actions/setup-python@v5 with: python-version: '3.11' - name: Build run: make compile-with-docker-all + - name: Run Tests + run: | # have to set up python? + make tests-with-docker - name: Release uses: softprops/action-gh-release@v2 with: - tag_name: ${{ github.event.inputs.releaseVersion }} + tag_name: v${{ github.event.inputs.releaseVersion }} files: | bin/aws-lambda-rie bin/aws-lambda-rie-arm64 From 8a44c78acc19dfc7467edff7ef68b143d786ad50 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 10:26:28 -0700 Subject: [PATCH 14/22] not working w main bc there is no main here --- .github/workflows/release.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ae09818..7f0b7f9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -6,7 +6,7 @@ on: releaseVersion: description: "Version to use for the release." required: true - default: "X.Y.Z" + default: "X.Y" # developmentVersion: #this could be the release notes?? # description: "Version to use for further development" # required: true @@ -17,8 +17,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: 'main' + # with: + # ref: 'main' - name: Set up python uses: actions/setup-python@v5 with: From 152775430566dcb6b9387fe3bb1894f9bc3b1f95 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 10:35:14 -0700 Subject: [PATCH 15/22] added main branch to test --- .github/workflows/release.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 7f0b7f9..20f225a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -7,7 +7,7 @@ on: description: "Version to use for the release." required: true default: "X.Y" - # developmentVersion: #this could be the release notes?? + # developmentVersion: #this could be the release body? # description: "Version to use for further development" # required: true # default: "X.Y.Z-RIE" @@ -17,8 +17,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - # with: - # ref: 'main' + with: + ref: 'main' - name: Set up python uses: actions/setup-python@v5 with: @@ -31,7 +31,9 @@ jobs: - name: Release uses: softprops/action-gh-release@v2 with: + name: Release ${{ github.event.inputs.releaseVersion }} tag_name: v${{ github.event.inputs.releaseVersion }} + body: This is the body files: | bin/aws-lambda-rie bin/aws-lambda-rie-arm64 From c88ed22e853ba1c2b2b81dd66a87633be8d8e393 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 10:51:32 -0700 Subject: [PATCH 16/22] Add release body --- .github/workflows/release.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 20f225a..48874f2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -7,10 +7,10 @@ on: description: "Version to use for the release." required: true default: "X.Y" - # developmentVersion: #this could be the release body? - # description: "Version to use for further development" - # required: true - # default: "X.Y.Z-RIE" + releaseBody: + description: "Information about the release" + required: true + default: "New release" jobs: Release: environment: Release @@ -33,7 +33,7 @@ jobs: with: name: Release ${{ github.event.inputs.releaseVersion }} tag_name: v${{ github.event.inputs.releaseVersion }} - body: This is the body + body: ${{ github.event.inputs.releaseBody }} files: | bin/aws-lambda-rie bin/aws-lambda-rie-arm64 From 2eb4faefb473f3f288aa6bd3c53c00d72843ce2d Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 11:33:32 -0700 Subject: [PATCH 17/22] added tests inside --- .github/workflows/release.yml | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 48874f2..03d9cfe 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -25,9 +25,23 @@ jobs: python-version: '3.11' - name: Build run: make compile-with-docker-all - - name: Run Tests - run: | # have to set up python? - make tests-with-docker + - name: Run Integ Tests + run: make tests-with-docker + - name: Run Integ Tests x86 + uses: actions/setup-python@v5 + with: + python-version: '3.11' + run: make integ-tests-with-docker-x86-64 + - name: Run Integ Tests arm64 + uses: actions/setup-python@v5 + with: + python-version: '3.11' + run: make integ-tests-with-docker-arm64 + - name: Run Integ Tests Old + uses: actions/setup-python@v5 + with: + python-version: '3.11' + run: make integ-tests-with-docker-old - name: Release uses: softprops/action-gh-release@v2 with: From 8b4f0a7edbb28274daecbbd5beb56b3abf7110f7 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 11:37:15 -0700 Subject: [PATCH 18/22] collapse tests --- .github/workflows/release.yml | 36 +++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 03d9cfe..f98fc20 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -26,22 +26,26 @@ jobs: - name: Build run: make compile-with-docker-all - name: Run Integ Tests - run: make tests-with-docker - - name: Run Integ Tests x86 - uses: actions/setup-python@v5 - with: - python-version: '3.11' - run: make integ-tests-with-docker-x86-64 - - name: Run Integ Tests arm64 - uses: actions/setup-python@v5 - with: - python-version: '3.11' - run: make integ-tests-with-docker-arm64 - - name: Run Integ Tests Old - uses: actions/setup-python@v5 - with: - python-version: '3.11' - run: make integ-tests-with-docker-old + run: | + make tests-with-docker + make integ-tests-with-docker-x86-64 + make integ-tests-with-docker-arm64 + make integ-tests-with-docker-old + # - name: Run Integ Tests x86 + # uses: actions/setup-python@v5 + # with: + # python-version: '3.11' + # run: make integ-tests-with-docker-x86-64 + # - name: Run Integ Tests arm64 + # uses: actions/setup-python@v5 + # with: + # python-version: '3.11' + # run: make integ-tests-with-docker-arm64 + # - name: Run Integ Tests Old + # uses: actions/setup-python@v5 + # with: + # python-version: '3.11' + # run: make integ-tests-with-docker-old - name: Release uses: softprops/action-gh-release@v2 with: From a57dc9553076bbff3e81926ce5eec58975a0d1b1 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 11:53:14 -0700 Subject: [PATCH 19/22] main branch bug? --- .github/workflows/release.yml | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f98fc20..363b21e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -8,7 +8,7 @@ on: required: true default: "X.Y" releaseBody: - description: "Information about the release" + description: "Information about the release" #not showing if main branch? and using old version of this file if on main branch???? required: true default: "New release" jobs: @@ -17,8 +17,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - with: - ref: 'main' + # with: + # ref: 'main' - name: Set up python uses: actions/setup-python@v5 with: @@ -31,21 +31,6 @@ jobs: make integ-tests-with-docker-x86-64 make integ-tests-with-docker-arm64 make integ-tests-with-docker-old - # - name: Run Integ Tests x86 - # uses: actions/setup-python@v5 - # with: - # python-version: '3.11' - # run: make integ-tests-with-docker-x86-64 - # - name: Run Integ Tests arm64 - # uses: actions/setup-python@v5 - # with: - # python-version: '3.11' - # run: make integ-tests-with-docker-arm64 - # - name: Run Integ Tests Old - # uses: actions/setup-python@v5 - # with: - # python-version: '3.11' - # run: make integ-tests-with-docker-old - name: Release uses: softprops/action-gh-release@v2 with: From 3c1e8aebb84db84f50b78b73863726d5c2c0cd47 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 12:02:32 -0700 Subject: [PATCH 20/22] Should work on main if the newer file is in main lol --- .github/workflows/release.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 363b21e..365e2d3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -8,7 +8,7 @@ on: required: true default: "X.Y" releaseBody: - description: "Information about the release" #not showing if main branch? and using old version of this file if on main branch???? + description: "Information about the release" required: true default: "New release" jobs: @@ -17,8 +17,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - # with: - # ref: 'main' - name: Set up python uses: actions/setup-python@v5 with: From 74a76a1c49ef172130bde4a57c59283484dc4b79 Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Thu, 9 May 2024 12:16:32 -0700 Subject: [PATCH 21/22] checkout main again --- .github/workflows/release.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 365e2d3..5d94f91 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,6 +17,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + with: + ref: main - name: Set up python uses: actions/setup-python@v5 with: From fb471300b8ba402826ee9fe395ef6e40d23533ad Mon Sep 17 00:00:00 2001 From: Seshu Brahma Date: Tue, 14 May 2024 11:41:07 -0700 Subject: [PATCH 22/22] Fixed integ tests section --- .github/workflows/release.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5d94f91..32e878d 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -28,9 +28,7 @@ jobs: - name: Run Integ Tests run: | make tests-with-docker - make integ-tests-with-docker-x86-64 - make integ-tests-with-docker-arm64 - make integ-tests-with-docker-old + make integ-tests - name: Release uses: softprops/action-gh-release@v2 with: