-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there an ETA for Configure method with ILambdaInvokeBuilder? #1714
Comments
@Nairda015 Good afternoon. Thanks for opening the issue. Please refer similar discussion started on #1688 (comment). Similar discussion #1683. Annotations doesn't leverage ASP.NET pipeline. I'm unsure if your use case is similar, could you please validate? Thanks, |
The design document just compares the existing old approach Vs. annotations. Needs review with the team. CC @normj |
I don't have a timeline but it is a feature I would like to get in there. |
Do you have a vision of how you would implement it or my idea about resolving the handler from DI with the interface and adding interceptors from Castle.Core is good enough? |
@normj will you accept PR with change to register handler with interface here? |
Describe the feature
Hey I want to create middleware or filter pipeline for lambda function
There is note about middleware in design doc but no information when it will happen
There are old PR without CR like this and idk if I should contribute
Use Case
global error handling, extracting standard headers like trace-id
Proposed Solution
I have workaround with more generated code and castle.core for intercepting calls
For class FunctionHandler I can generate IFunctionHandler and FunctionHandlerWrapper.
Next I can call FunctionHandler from FunctionHandlerWrapper.
Also need to register FunctionHandler as TryAddSingleton<IFunctionHandler, FunctionHandler> so it is interceptable.
Maybe before full middleware pipeline implementation can we add option to generate IFunctionHandler by the annotation framework and resolve it from DI by interface in generated code?
Other Information
No response
Acknowledgements
AWS .NET SDK and/or Package version used
Amazon.Lambda.Annotations --version 1.2.0
Targeted .NET Platform
.NET 6
Operating System and version
AmazonLinux
The text was updated successfully, but these errors were encountered: