Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default padding for RSA keyrings #350

Open
seebees opened this issue May 29, 2020 · 1 comment
Open

Remove the default padding for RSA keyrings #350

seebees opened this issue May 29, 2020 · 1 comment

Comments

@seebees
Copy link
Contributor

seebees commented May 29, 2020

The default was added when Node.js only supported OAEP-SHA-1-MFG1-SHA1,
but in v12 all the SHA flavors were added.

Having a default of SHA-1 when SHA-256 is available is a bad customer experience.
Since these values must agree on the keyring used to encrypt and the keyring to decrypt,
and this value will advance as the world changes,
having a default for this is a bad idea.

@seebees
Copy link
Contributor Author

seebees commented May 29, 2020

Also, all examples should be updated to SHA-256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant