-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client-browser readme is missing fallback strategies and alternatives #128
Comments
Hi, Any further information on this is really helpful, we currently have requirement where we are using AWS encryption SDK for browser using javascript and we are facing compatibility issues with safari browser on MAC and iOS devices. If any information on this will be helpful, till readme documentation is updated. |
@khadir-syed Safari does not support Zero-Byte AES-GCM operations. So a fallback (such as msrcrypto) is needed. Even though WebCrypto is supported. |
@seebees - Thanks for your reply. As per below documentation client-browser module, I configured fallback and still seeing issue. ============================ WebCrypto availability
For details on configureFallback see: @aws-crypto/web-crypto-backend ============================ Mainly error is coming in configureFallback function. This is the error. Unhandled Promise Rejection: Error: A Fallback is required for zero byte AES-GCM operations. Do I need to do any spec \ additional changes in web-crypto-backend module? Thanks in advance. |
If you have a public repo I could take a look. Are you sure that you are not getting an error on |
@seebees - you can check this public code repo - https://github.com/khadir-syed/aws_sdk_encryption_js_poc I have done changes in these files - https://github.com/khadir-syed/aws_sdk_encryption_js_poc/blob/master/node_modules/%40aws-crypto/example-browser/src/aes_simple.ts where I added below code
msrCrypto is present in node_modules here - https://github.com/khadir-syed/aws_sdk_encryption_js_poc/tree/master/node_modules/%40aws-crypto/example-browser/node_modules aes_simple_bundle.js - is created using msrcrypto.js - This I referenced in above html file, below is for your reference.
Also, I am attaching screen shots from chrome and safari browers on MAC machine I am testing... Any help here is much appreciated, as I am struck on this from sometime. |
The fallback conversation was resolved by #239, |
The fallback section of the readme for the client-browser module lists the features of the SDK that are not supported by certain browsers. However, while it mentions
msrcrypto
as an example of a fallback library, it doesn't recommend any fallback strategies or alternatives.Also, the fallback section points to @aws-crypto/web-crypto-backend, but that file has very little information, and just sends readers back to the readme. Loops like this are very frustrating to users.
The text was updated successfully, but these errors were encountered: