Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS SDK Go dependency in amazon-vpc-cni-k8s to SDK V2 #3116

Closed
orsenthil opened this issue Nov 18, 2024 · 1 comment
Closed

Update AWS SDK Go dependency in amazon-vpc-cni-k8s to SDK V2 #3116

orsenthil opened this issue Nov 18, 2024 · 1 comment

Comments

@orsenthil
Copy link
Member

orsenthil commented Nov 18, 2024

Current version of Amazon VPC CNI plugin (below 1.19.0) relies on the AWS SDK for Go v1 (SDK v1) to interact with AWS services. However, SDK v1 will enter maintenance mode and reach end-of-support on July 31, 2025.
This requires us to migrate AWS VPC CNI plugin to AWS SDK V2. The AWS SDK for Go v2 (SDK v2) is a complete redesign of the Go SDK code, incorporating idiomatic Go practices and increased modularity in AWS service dependencies.

Migrating to SDK v2 (https://aws.github.io/aws-sdk-go-v2/docs/migrating/) requires significant refactoring due to architectural changes.Since the types between SDK v1 and v2 are different, this means that the entire codebase must be migrated to SDK v2 in a single step.

A full migration of the entire codebase in a single shot can present challenges in terms of testing, code review, and the potential introduction of regressions.To mitigate these potential pitfalls, the approach to migration will be as follows:

  1. Migrate against an upstream branch sdkv2 (https://github.com/aws/amazon-vpc-cni-k8s/tree/sdkv2). This branch will be merged into the master branch after review and testing.
  2. Migrate independent clients in small pull requests against the SDK v2 branch.
  3. Implement the SDK v2 configuration logic, then update the client call code paths.
  4. Ensure that unit tests and integration tests are successful with every pull request.
Copy link

github-actions bot commented Dec 9, 2024

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant