Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Potential miscalculation in WARM_PREFIX_TARGET, WARM_IP_TARGET, MINIMUM_IP_TARGET docs #3083

Open
Tsonov opened this issue Oct 22, 2024 · 1 comment
Labels
bug stale Issue or PR is stale

Comments

@Tsonov
Copy link

Tsonov commented Oct 22, 2024

Not a product issue but potential documentation bug.

I could be misunderstanding how the WARM/MIN calculations work, or the following line from docs/prefix-and-ip-target.md is wrong.

Since MINIMUM_IP_TARGET=20, CNI attaches 2 prefixes (32 IPs) to ensure 20 are available. There are no pods to use any IPs so all 32 IPs are Unused.

So last column should say 32 instead of 16 and Attached Prefixes+Unused Prefixes should say 2 instead of 1. Is that the case or the calculation above is not OK?

AFAICS WARM_IP_TARGET has no effect in this case, right?

Instance type WARM_PREFIX_TARGET WARM_IP_TARGET MINIMUM_IP_TARGET Pods ENIs Pod per ENIs Attached Prefixes Pod per Prefixes Unused Prefixes Prefixes per ENI Unused IPs
t3.small - 7 20 0 1 0 1 0,0 1 2 16
@Tsonov Tsonov added the bug label Oct 22, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale Issue or PR is stale
Projects
None yet
Development

No branches or pull requests

1 participant