Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced subnet discovery should use configurable tags #2904

Open
dougbyrne opened this issue May 2, 2024 · 6 comments
Open

Enhanced subnet discovery should use configurable tags #2904

dougbyrne opened this issue May 2, 2024 · 6 comments

Comments

@dougbyrne
Copy link
Contributor

What would you like to be added: The enhanced subnet discovery should use configurable tags. Currently the CNI will use any subnet in a matching VPC and AZ with the tag kubernetes.io/role/cni: 1. The CNI should have additional configurable tag filters.

Why is this needed: If multiple EKS clusters share a VPC, they will all share subnets. It is desirable to specify additional tags unique to each cluster to limit the discovery scope. An example filter might be kubernetes.io/cluster/my-example-cluster: shared.

Subnet ID tag kubernetes.io/role/cni tag kubernetes.io/cluster/my-example-cluster tag kubernetes.io/cluster/some-other-cluster Selected by my example cluster Selected by some other cluster
subnet-123 1 shared untagged ✅ Yes ❌ No
subnet-456 1 untagged shared ❌ No ✅ Yes
subnet-789 1 shared shared ✅ Yes ✅ Yes
subnet-abc untagged shared untagged ❌ No ❌ No
subnet-def untagged untagged untagged ❌ No ❌ No
Copy link

github-actions bot commented Jul 2, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Jul 2, 2024
@dougbyrne
Copy link
Contributor Author

Unstale

@github-actions github-actions bot removed the stale Issue or PR is stale label Jul 26, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Sep 24, 2024
@dougbyrne
Copy link
Contributor Author

Unstale

@github-actions github-actions bot removed the stale Issue or PR is stale label Sep 25, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Nov 24, 2024
@lorengordon
Copy link

Unstale

@github-actions github-actions bot removed the stale Issue or PR is stale label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants