Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynatrace exporter config docs mention invalid key #253

Open
arminru opened this issue Feb 25, 2022 · 4 comments
Open

Dynatrace exporter config docs mention invalid key #253

arminru opened this issue Feb 25, 2022 · 4 comments
Assignees

Comments

@arminru
Copy link
Contributor

arminru commented Feb 25, 2022

The docs in https://aws-otel.github.io/docs/partners/dynatrace still list the config key insecure_skip_verify at top-level although this config was restructured in the collector a while ago (see the collector readme) and nested into a section tls.
This is the same issue as reported here: open-telemetry/opentelemetry-collector-contrib#7566
The exporter readme in the collector was fixed in open-telemetry/opentelemetry-collector-contrib@6cfac22 and open-telemetry/opentelemetry-collector-contrib@c8dc4b9.

Initially filed as aws-observability/aws-otel-community#55.

@arminru
Copy link
Contributor Author

arminru commented Feb 25, 2022

Additionally there were quite a few more additions, improvements and fixes:
https://github.com/open-telemetry/opentelemetry-collector-contrib/commits/main/exporter/dynatraceexporter/README.md

Is there any way to keep these in sync or do all changes need to be reflected manually on the corresponding ADOT docs page?

@bryan-aguilar
Copy link
Contributor

Hi @arminru,

Would you rather us just link to the upstream README for the dynatrace exporter?

@arminru
Copy link
Contributor Author

arminru commented Apr 13, 2022

Hey @bryan-aguilar! This would certainly work but I think it might be surprising or even confusing if it would differ in that regard from all of the other components.
Copying the latest version over once again should be fine as there aren't too many changes applied upstream anyway. I was just wondering if there is any sync tool or templating to include the fragment from upstream, or if that's always updated manually.

@bryan-aguilar
Copy link
Contributor

Right now all website pages are managed manually. It would be nice to move toward a single point of truth for the information to reduce the maintenance burden of keeping the docs up to date in multiple locations.

It would also be very nice if there was some type of sync tool we could use for this. I'll make a note to look into that before making any other changes.

Feel free to submit a PR if you see anything that is missing or could be updated before someone on the team addresses it.

@bryan-aguilar bryan-aguilar self-assigned this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants