-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[windows][CI/CD] ADOT collector delayed start #1767
Comments
Updates: ADOT collector agent has been crashing sometimes at windows system reboot. This behaviour has been experienced by other projects and it seems to be a bug in golang. The issue is currently being tracked golang/go#23479 Testing This issue has been tough to replicate as it is a probabilistic failure which occurs to some windows instances from a large fleet of machines. This limitation on not able replicate the issue every-time has been mentioned on the linked issue too. SO we need to come up with a testing strategy to set up a mock env with these condition to run across these failures. Proposed Solution Out of all proposed workaround mentioned in the issue thread, one approach found that having delayed start to the application has decreased the probability of the agent failing to start up (Still not 0% but better than before ).This is implemented in #1788 . Considering this change just delays the start of the ADOT collector, it has a comparatively low blast radius/affect on our customer. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This issue was closed because it has been marked as stale for 30 days with no activity. |
Refer to PR #1788 for additional discussion. |
I using a WinSW to handling service ADOTCollector service. Its working in windows-aws-ecs-fargate. |
Describe the bug
Sets ADOT collector agent as Automatic (delayed start) services to mitigate known go windows issues with 1.9.2: golang/go#23479
Services would not restart across reboots on Automatic services, they would timeout before coming up and the service control manager would give up spawning them. This workaround will be reverted back once's it is believed to addressed in the future golang releases
The text was updated successfully, but these errors were encountered: