Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfnLint.path doesn't resolve ${workspaceFolder} #27

Open
bwilder opened this issue Oct 29, 2018 · 3 comments
Open

cfnLint.path doesn't resolve ${workspaceFolder} #27

bwilder opened this issue Oct 29, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@bwilder
Copy link

bwilder commented Oct 29, 2018

Hi,
I was having a hard time getting this extension to work until I found #21.

> Determined this file is a CloudFormation Template. file:///Users/user/test/test.yml. Found the string AWSTemplateFormatVersion
> running............. ${workspaceFolder}/venv/bin/cfn-lint --format,json,--template,/Users/user/test/test.yml
> Unable to start cfn-lint (Error: spawn ${workspaceFolder}/venv/bin/cfn-lint ENOENT). Is cfn-lint installed correctly?

After doing a which cfn-lint, grabbing the results, and making that the value of `cfnLint.Path, things started working.

Determined this file is a CloudFormation Template. file:///Users/user/test/test.yml. Found the string AWSTemplateFormatVersion
running............. /Users/user/test/venv/bin/cfn-lint --format,json,--template,/Users/user/test/test.yml

Looks like ${workspaceFolder} isn't being resolved. Is this the expected behavior?

@cmmeyer
Copy link

cmmeyer commented Oct 30, 2018

Hey there, thanks for raising this!

I don't think we currently process VS Code Predefined Variables in our settings, so your resolution is correct. If it's alright with you, I'm going to treat this as an enhancement to add the ability to use VS Code predefined variables (as defined here: https://code.visualstudio.com/docs/editor/variables-reference) when defining linter settings.

@cmmeyer cmmeyer added the enhancement New feature or request label Oct 30, 2018
@bwilder
Copy link
Author

bwilder commented Oct 31, 2018

Sure thing, thanks!

@kddejong
Copy link
Contributor

This is the best I can do for now. Looks like this is a common issue when using settings. microsoft/vscode#2809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants