Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: allowed-account-ids (to prevent accidents) #432

Open
ghostsquad opened this issue Apr 28, 2022 · 1 comment
Open

add: allowed-account-ids (to prevent accidents) #432

ghostsquad opened this issue Apr 28, 2022 · 1 comment
Labels
effort/small This issue will take less than a day of effort to fix feature-request A feature should be added or improved. p2

Comments

@ghostsquad
Copy link

Similar to the terraform provider feature:

allowed_account_ids - (Optional) List of allowed AWS account IDs to prevent you from mistakenly using an incorrect one (and potentially end up destroying a live environment). Conflicts with forbidden_account_ids.
@ghostsquad ghostsquad mentioned this issue Apr 28, 2022
Closed
@peterwoodworth peterwoodworth added the needs-triage This issue still needs to be triaged label Oct 1, 2022
@peterwoodworth
Copy link
Contributor

I can see how this would be useful, thank you for the suggestion! We should be able to make a check for this pretty easily

@peterwoodworth peterwoodworth added good first issue Good for newcomers p2 effort/small This issue will take less than a day of effort to fix and removed needs-triage This issue still needs to be triaged labels Oct 11, 2022
jacksonwelsh added a commit to jacksonwelsh/configure-aws-credentials that referenced this issue Dec 18, 2022
@jacksonwelsh
feat: allow-list option for aws account id
a49adeb 
Users may set the `allowed-account-ids` input variable to define a
comma-separated list of accounts that may be authenticated against.

Resolves aws-actions#432
jacksonwelsh added a commit to jacksonwelsh/configure-aws-credentials that referenced this issue Dec 18, 2022
@jacksonwelsh
feat: allow-list option for aws account id
b1d1374 
Users may set the `allowed-account-ids` input variable to define a
comma-separated list of accounts that may be authenticated against.

Resolves aws-actions#432
jacksonwelsh added a commit to jacksonwelsh/configure-aws-credentials that referenced this issue Dec 18, 2022
@jacksonwelsh
feat: allow-list option for aws account id
d0d9c0e 
Users may set the `allowed-account-ids` input variable to define a
comma-separated list of accounts that may be authenticated against.

Resolves aws-actions#432
jacksonwelsh added a commit to jacksonwelsh/configure-aws-credentials that referenced this issue Dec 18, 2022
@jacksonwelsh
feat: allow-list option for aws account id
401b835 
Users may set the `allowed-account-ids` input variable to define a
comma-separated list of accounts that may be authenticated against.

Resolves aws-actions#432
@jacksonwelsh jacksonwelsh mentioned this issue Dec 18, 2022
Closed
1 task
@peterwoodworth peterwoodworth added the feature-request A feature should be added or improved. label Feb 22, 2023
@peterwoodworth peterwoodworth removed the good first issue Good for newcomers label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small This issue will take less than a day of effort to fix feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow-list option for aws account id jacksonwelsh/configure-aws-credentials
2 participants
@ghostsquad @peterwoodworth