From b632f8d6ade4bd211939a271b6249ae632954082 Mon Sep 17 00:00:00 2001 From: Joseph Schorr Date: Fri, 30 Aug 2024 18:17:43 -0400 Subject: [PATCH] Make the max size exceeded error public --- internal/datastore/common/changes.go | 2 +- internal/datastore/common/errors.go | 11 ----------- pkg/datastore/errors.go | 11 +++++++++++ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/internal/datastore/common/changes.go b/internal/datastore/common/changes.go index 956576543a..9449e47a5a 100644 --- a/internal/datastore/common/changes.go +++ b/internal/datastore/common/changes.go @@ -119,7 +119,7 @@ func (ch *Changes[R, K]) adjustByteSize(item sized, delta int) error { } if ch.currentByteSize > int64(ch.maxByteSize) { - return NewMaximumChangesSizeExceededError(ch.maxByteSize) + return datastore.NewMaximumChangesSizeExceededError(ch.maxByteSize) } return nil diff --git a/internal/datastore/common/errors.go b/internal/datastore/common/errors.go index b8a24dae5c..81537bab84 100644 --- a/internal/datastore/common/errors.go +++ b/internal/datastore/common/errors.go @@ -153,14 +153,3 @@ type RevisionUnavailableError struct { func NewRevisionUnavailableError(err error) error { return RevisionUnavailableError{err} } - -// MaximumChangesSizeExceededError is returned when the maximum size of changes is exceeded. -type MaximumChangesSizeExceededError struct { - error - maxSize uint64 -} - -// NewMaximumChangesSizeExceededError creates a new MaximumChangesSizeExceededError. -func NewMaximumChangesSizeExceededError(maxSize uint64) error { - return MaximumChangesSizeExceededError{fmt.Errorf("maximum changes byte size of %d exceeded", maxSize), maxSize} -} diff --git a/pkg/datastore/errors.go b/pkg/datastore/errors.go index 87642cca04..d5f1313a00 100644 --- a/pkg/datastore/errors.go +++ b/pkg/datastore/errors.go @@ -263,6 +263,17 @@ func (err ErrCounterAlreadyRegistered) DetailsMetadata() map[string]string { } } +// MaximumChangesSizeExceededError is returned when the maximum size of changes is exceeded. +type MaximumChangesSizeExceededError struct { + error + maxSize uint64 +} + +// NewMaximumChangesSizeExceededError creates a new MaximumChangesSizeExceededError. +func NewMaximumChangesSizeExceededError(maxSize uint64) error { + return MaximumChangesSizeExceededError{fmt.Errorf("maximum changes byte size of %d exceeded", maxSize), maxSize} +} + var ( ErrClosedIterator = errors.New("unable to iterate: iterator closed") ErrCursorsWithoutSorting = errors.New("cursors are disabled on unsorted results")