Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification #344

Closed
11 tasks done
sonle-geekyants opened this issue Oct 21, 2023 · 2 comments
Closed
11 tasks done

Improve notification #344

sonle-geekyants opened this issue Oct 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@sonle-geekyants
Copy link
Contributor

sonle-geekyants commented Oct 21, 2023

Describe the remaining issues

  • Both desktop and mobile versions have these same UI issues

  • Unselected notification button
    Expected:
    image
    Actual:
    image

  • Sending queue
    Expected:
    image
    Actual:
    image

  • Notification cards
    Expected:
    image
    Actual:
    image

  • Expanded card
    Expected:
    image
    Actual:
    image

  • Missing ! and Error badges
    Ảnh chụp màn hình 2023-10-27 040038

  • sending and files must have the first letter uppercase and need to adjust the spacing
    Expected:
    image
    Actual:
    image

  • All items (including cards and badges) of the mobile version in design seem to have different padding and sizes compared to the desktop one

  • Maybe try to use shrinkWrap for ListView instead of using fixed height

  • Some fontWeight are not as same as the design

  • We need to remove the unread counter on the notification icon after tapping in

  • About a "Cancel" button - Should we need to add it to the app?
    Ảnh chụp màn hình 2023-10-27 040924

@sachins-geekyants
Copy link
Contributor

Updated the design in this PR : #342

@sonle-geekyants
Copy link
Contributor Author

Updated the design in this PR : #342

@sachins-geekyants Added some new issues!

@ksanty ksanty added the enhancement New feature or request label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants