Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Key format added to spec #46

Open
XavierChanth opened this issue Mar 3, 2023 · 4 comments
Open

General Key format added to spec #46

XavierChanth opened this issue Mar 3, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@XavierChanth
Copy link
Member

Is your feature request related to a problem? Please describe.

When explaining the underlying key structure, it was very difficult until I pulled up this old slidedeck:
CleanShot 2023-03-03 at 16 03 10

Describe the solution you'd like

A general format key listed before the 5 variations, preferably as a diagram, and avoiding heavy regex syntax. (The idea is that it would give you a general understanding of the format, before reading about each one's details)

Describe alternatives you've considered

No response

Additional context

Would love some feedback on this idea, I know something like this isn't necessary in a specification, but it would make the specification a lot more understandable.

@gkc
Copy link
Contributor

gkc commented Apr 3, 2023

I've covered this in a larger update to the protocol spec. Keeping in sprint but reducing SP to 0

@gkc
Copy link
Contributor

gkc commented Apr 17, 2023

Didn't get as far as getting changes reviewed in PR59; moving to PR60 for completion

@XavierChanth XavierChanth self-assigned this May 2, 2023
@XavierChanth
Copy link
Member Author

Can this be closed @gkc

@gkc
Copy link
Contributor

gkc commented May 16, 2023

Not yet; didn't get more time on this in last couple of sprints, will prioritize the work to finish off my in-flight protocol spec update this week

@XavierChanth XavierChanth removed their assignment Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants