Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar stuck in overlay mode when page width is increased #908

Open
rijenkii opened this issue Feb 3, 2024 · 6 comments
Open

Sidebar stuck in overlay mode when page width is increased #908

rijenkii opened this issue Feb 3, 2024 · 6 comments
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com

Comments

@rijenkii
Copy link

rijenkii commented Feb 3, 2024

Description

When opening the sidebar through the hamburger button on bottom right of the screen, and then increasing the width of the preview, sidebar is still drawn in the overlay mode.

Reproduced on Firefox 121 and Chromium 120.0.6099.216, Fedora 39.

Steps to reproduce

Paste the following into the playground:

Schema
{
  "asyncapi": "3.0.0",
  "info": {
    "title": "Reproduction",
    "version": "1.0.0"
  },
  "operations": {
    "test": {
      "action": "receive",
      "channel": { "$ref": "#/channels/test" }
    }
  },
  "channels": {
    "test": {
      "address": "/test",
      "messages": {
        "test": { "$ref": "#/components/messages/test" }
      }
    }
  },
  "components": {
    "messages": {
      "test": {
        "payload": {
          "type": "object",
          "properties": {
            "test": {
              "description": "test",
              "type": "string",
              "pattern": "^(?:helloworld)+$"
            }
          },
          "required": ["test"]
        }
      }
    }
  }
}
Configuration
{
  "show": {
    "sidebar": true,
    "info": true,
    "operations": true,
    "servers": true,
    "messages": true,
    "schemas": true,
    "errors": true
  },
  "expand":{
    "messageExamples": false
  },
  "sidebar": {
    "showServers": "byDefault",
    "showOperations": "byDefault"
  }
}

Click on the hamburger button.
Increase width of the preview side of the screen.

Expected result

Overlay sidebar is closed, regular sidebar is drawn instead.

Actual result

Screencast.from.2024-02-03.14-53-07.webm

Troubleshooting

N/A

Copy link

github-actions bot commented Jun 3, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 3, 2024
@rijenkii
Copy link
Author

rijenkii commented Jun 3, 2024

Still an issue.

@github-actions github-actions bot removed the stale label Jun 4, 2024
@AceTheCreator AceTheCreator added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Sep 30, 2024
@AceTheCreator
Copy link
Member

You mean something like this? @rijenkii ?

AsyncAPI.React.Playground.App.mp4

@rijenkii
Copy link
Author

rijenkii commented Oct 3, 2024

Click the hamburger button and expand the right panel all the way out, to the breakpoint that shows the regular sidebar. You haven't expanded it far enough on the video. Reproduction from OP still works, just like the video in the OP.

@AceTheCreator
Copy link
Member

@rijenkii
Copy link
Author

rijenkii commented Oct 4, 2024

Yes, something like this. The bug is still reproducible on https://asyncapi.github.io/asyncapi-react/ though:

Screencast.from.2024-10-04.23-03-42.webm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

2 participants