Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MSSQL's prepared statements #13

Open
jeffkreeftmeijer opened this issue Mar 12, 2018 · 4 comments
Open

Support MSSQL's prepared statements #13

jeffkreeftmeijer opened this issue Mar 12, 2018 · 4 comments
Labels
bug support

Comments

@jeffkreeftmeijer
Copy link
Member

jeffkreeftmeijer commented Mar 12, 2018 •
edited
Loading

As reported via support (private Intercom link):

As you can see the SQL reported by MSSQL is performed using prepared statements, with the sanitisation applied the actual query being performed is removed and replaced with a question mark.

ActiveRecord seems to wrap all queries in prepare statements, which the sql_lexer can't handle right now, resulting in queries like this:

screen shot 2018-03-06 at 19 54 18

Also, here's how to set up MSSQL on your fancy Apple-Books, kids. 👴🏻
@tombruijn tombruijn added the bug label Mar 12, 2018
@tombruijn tombruijn changed the title Support MSSQL's pepared statements 🐞 Support MSSQL's pepared statements Mar 12, 2018
@tombruijn tombruijn changed the title 🐞 Support MSSQL's pepared statements 🐞 Support MSSQL's prepared statements Mar 12, 2018
@jeffkreeftmeijer
Copy link
Member Author

https://app.intercom.io/a/apps/yzor8gyw/inbox/inbox/540654/conversations/16660986713

@tombruijn tombruijn changed the title 🐞 Support MSSQL's prepared statements Support MSSQL's prepared statements May 30, 2018
@jeffkreeftmeijer
Copy link
Member Author

https://app.intercom.io/a/apps/yzor8gyw/inbox/inbox/unassigned/conversations/19423502644

@jeffkreeftmeijer
Copy link
Member Author

https://app.intercom.io/a/apps/yzor8gyw/inbox/inbox/540654/conversations/25252473951

@jeffkreeftmeijer
Copy link
Member Author

https://app.intercom.com/a/inbox/yzor8gyw/inbox/shared/unassigned/conversation/16410700312839?view=TableFullscreen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffkreeftmeijer @tombruijn