Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golden Logit tests to ensure Fuji v2 70B matches Llama 2 70B #687

Open
samos123 opened this issue Sep 5, 2024 · 0 comments
Open

Golden Logit tests to ensure Fuji v2 70B matches Llama 2 70B #687

samos123 opened this issue Sep 5, 2024 · 0 comments

Comments

@samos123
Copy link
Contributor

samos123 commented Sep 5, 2024

https://github.com/google/maxtext/blob/26a5292bd9f55bd3ff9b2010cd7a86491e9c7b15/end_to_end/tpu/llama2/70b/2_test_llama2_70b.sh#L63

https://github.com/google/maxtext/blob/main/MaxText/scratch_code/golden_llama2-70b_export.py

thats what maxtext does to guarantee that the implementation is identical to official llama 2 70B

It would be good to do the same to ensure that AXLearn models are proper implementations too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant