Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor new telemetry module #5607

Open
bnjjj opened this issue Jul 4, 2024 · 0 comments
Open

Refactor new telemetry module #5607

bnjjj opened this issue Jul 4, 2024 · 0 comments
Assignees
@bnjjj
Labels
component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it.

Comments

@bnjjj
Copy link
Contributor

bnjjj commented Jul 4, 2024

But please can you follow up by moving the selectors to src/configuration/selectors.
Also it'd be good to have a separate file for each type of selector, so we would end up with:
src/configuration/selectors/router.rs
src/configuration/selectors/supergraph.rs

etc.

Originally posted by @BrynCooke in #5557 (review)

Also that should be good to get rid of config_new in telemetry module
@bnjjj bnjjj self-assigned this Jul 4, 2024
@abernix abernix added the component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnjjj bnjjj

Labels
component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abernix @bnjjj