Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unit tests and E2E from using host ports 3181 and 18181 #2410

Open
2 tasks
linghengqian opened this issue Jul 28, 2024 · 0 comments
Open
2 tasks

Prevent unit tests and E2E from using host ports 3181 and 18181 #2410

linghengqian opened this issue Jul 28, 2024 · 0 comments

Comments

@linghengqian
Copy link
Member

linghengqian commented Jul 28, 2024

Feature Request

For English only, other languages will not accept.

Please pay attention on issues you submitted, because we maybe need more details.
If no response anymore and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

Describe the feature you would like.

  • In Prevent unit tests and E2E from using host ports 1, 2181, 7181, 8181, 8899, 9000, 9181, 9872 and 9875 #2409, most of the host port usage has been removed, but a few unit tests are still hard-coded into Spring Boot and properties configuration files.

    • spring/boot-starter/src/test/resources/application-snapshot.yml
    • spring/boot-starter/src/test/resources/application-elasticjob.yml
    • spring/boot-starter/src/test/resources/application-tracing.yml
    • spring/namespace/src/test/resources/conf/job/conf.properties
    • spring/namespace/src/test/resources/conf/reg/conf.properties
  • This is needed to prevent unit tests and E2E from using host ports 3181 and 18181. Maybe we need to introduce some means of dynamically defining configuration files.

  • Removes use of host port 3181.

  • Removes use of host port 18181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant