-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve exception handling and logging in baremaps #770
Comments
This is also required to stop a workflow run, if there is an error in a previous step:
And yes: This means that the current documented example is broken with 0.7.1 Someone already spotted this issue: #743 (comment) [Update] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd like to improve the way we trigger and handle exception in baremaps. At the moment, baremaps mostly use checked exceptions. This is problematic because we extensively rely on the Stream API which does not support checked exception. Therefore, we may be tempted to introduce the folling kind of exception caching and rethrowing code in the codebase (pseudo-code):
In addition to being unreadable, it is easy to forget to log exceptions correctly as reported in #763.
My current opinion is that we should use uncatched exceptions instead of checked exception in the API and let the error propagate several levels up. We should then systematically catch and log them at the level of the workflow executor. In addition to being more readable and reducing the amount code related to exception handling, this approach may enable us to build comprehensive execution reports.
@Perdjesk @polastre What do you think?
The text was updated successfully, but these errors were encountered: