Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codecov isn't able to upload when PR is from forks #8972

Closed
rohityadavcloud opened this issue Apr 24, 2024 · 4 comments
Closed

codecov isn't able to upload when PR is from forks #8972

rohityadavcloud opened this issue Apr 24, 2024 · 4 comments

Comments

@rohityadavcloud
Copy link
Member

PRs from fork (not this repo's own branch) isn't able to upload codecov results as the CODECOV_TOKEN isn't accessible to the GitHub action workflow.

ISSUE TYPE
  • Bug Report
COMPONENT NAME
Github Actions
@rohityadavcloud
Copy link
Member Author

Example https://github.com/apache/cloudstack/actions/runs/8820758171/job/24215084459?pr=8968

@rohityadavcloud
Copy link
Member Author

This may need use of https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@rohityadavcloud
Copy link
Member Author

I've bumped version used across 4.18-4.19-main branches to use v4; since they only get kicked when changes are on the branch; I've merged/fwd-merged changes directly on these branches.

@rohityadavcloud
Copy link
Member Author

Seems to have been fixed now with the v4 fix, #8968 (comment)
Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rohityadavcloud @DaanHoogland