[Bug] Errors thrown by gpinitsystem during locale checking

[xanadu-dev]

Cloudberry Database version

1.5.3

What happened

When initialising a new database there are errors thrown during locale checking - the database is initialized correctly so these errors appear to be benign
Error 1
/usr/local/cloudberrydb/bin/gpinitsystem: line 708: [1: command not found
relates to line

 if [ `$LOCALE -a |$GREP -ic $(NORMALIZE_CODESET_IN_LOCALE $LOCALE_SETTING)` -eq 0 ] \
    && [`$LOCALE -a |$GREP -ic $LOCALE_SETTING` -eq 0];then

Error 2
/usr/local/cloudberrydb/bin/gpinitsystem: line 721: [1: command not found
relates to line

if [ $( REMOTE_EXECUTE_AND_GET_OUTPUT $1 "$LOCALE -a|$GREP -ic '$(NORMALIZE_CODESET_IN_LOCALE $LOCALE_SETTING)'" ) -eq 0 ] \
    && [$( REMOTE_EXECUTE_AND_GET_OUTPUT $1 "$LOCALE -a|$GREP -ic '$LOCALE_SETTING'" ) -eq 0] ;then

What you think should happen instead

No response

How to reproduce

Comment used was

gpinitsystem -a -p $GPHOME/postgresql.conf -c $GPHOME/gpinitsystem_config -h $GPHOME/hostfile_gpinitsystem -l /gpadminlogs --mirror-mode=spread --su_password=$SUPERUSER_PASSWORD --locale=C.UTF-8

Operating System

Ubuntu 18.04

Anything else

Happens every time

Are you willing to submit PR?

• Yes, I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct.

[github-actions]

Hey, @xanadu-dev welcome!🎊 Thanks for taking the time to point this out.🙌

[yjhjstz]

Can you add system PATH to env : refer to greenplum-db/gpdb-archive@9201a8b

if work fine, I will cherry pick this.

[xanadu-dev]

Can you add system PATH to env : refer to greenplum-db/gpdb-archive@9201a8b

if work fine, I will cherry pick this.

I should be able to try this in the next few days and will let you know

[xanadu-dev]

Can you add system PATH to env : refer to greenplum-db/gpdb-archive@9201a8b

if work fine, I will cherry pick this.

I tried the change you suggested and it didn't remove the warnings
I'll update my system to the latest cloudberry version and check again as I am using 1.5.4 at the moment

[xanadu-dev]

I tried the change you suggested and it didn't remove the warnings I'll update my system to the latest cloudberry version and check again as I am using 1.5.4 at the moment

That suggested fix didn't work with version 1.6.0 either

[yjhjstz]

I tried the change you suggested and it didn't remove the warnings I'll update my system to the latest cloudberry version and check again as I am using 1.5.4 at the moment

That suggested fix didn't work with version 1.6.0 either

found another related pr: greenplum-db/gpdb-archive@e449c8c