Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjusting the page layout #1027

Closed
juxianzheng opened this issue Apr 13, 2022 · 6 comments
Closed

chore: Adjusting the page layout #1027

juxianzheng opened this issue Apr 13, 2022 · 6 comments
Assignees
Labels
Discuss good first issue Good for newcomers

Comments

@juxianzheng
Copy link
Contributor

juxianzheng commented Apr 13, 2022

Current State

Description of the current state/issue:The current layout looks too small, need to adjust the layout to a larger

Link to the page:https://apisix.apache.org/zh/showcase/

Screenshots (if relevant):
image

Desired State

Description of the change you are proposing:
Make the layout bigger

Would you like to fix this issue?

Yes! Count me in

@juxianzheng juxianzheng changed the title [Site]: Adjusting the page layout choreSite: Adjusting the page layout Apr 13, 2022
@juxianzheng juxianzheng changed the title choreSite: Adjusting the page layout chore: Adjusting the page layout Apr 13, 2022
@SkyeYoung
Copy link
Member

Sry. Can you please tell me why we need this improvement? And what are your goals for improvement? I think this is something that needs to be discussed, rather than just starting to do it.

@juxianzheng
Copy link
Contributor Author

对不起。你能告诉我为什么我们需要这种改进吗?您的改进目标是什么?我认为这是需要讨论的事情,而不是刚开始做。

I made a change just now, do you see it like this?

@SkyeYoung
Copy link
Member

I made a change just now, do you see it like this?

@juxianzheng I understand. But I think we need to make the logo bigger more than the layout. The larger layout does not make the layout look better.

@guoqqqi
Copy link
Member

guoqqqi commented Apr 15, 2022

@juxianzheng
As I recall there are three sections that need to be changed here

  • change the logo to a high-definition
  • the logo should be unified, for example, Tik-Tok Travel - the black background does not match with others
  • better adjust the page layout? Now it looks too small.

@SkyeYoung
Copy link
Member

@guoqqqi Hi, for the first and second tasks, we already have the corresponding issues, it's #580.

@SkyeYoung
Copy link
Member

SkyeYoung commented Apr 15, 2022

@juxianzheng Pls create a PR for an issue if possible.

Like I said, pls complete the corresponding changes in #580.
Also we can discuss whether it is really better to make the layout bigger. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discuss good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants