Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AES256-encrypted values for sensitive parameters in configs, env variables etc. #45194

Open
2 tasks done
andrii-korotkov-verkada opened this issue Dec 24, 2024 · 0 comments · May be fixed by #45195
Open
2 tasks done
Labels
area:secrets kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet

Comments

@andrii-korotkov-verkada

Description

Support config values like fernet_key_encrypted, env variables like AIRFLOW__CORE__FERNET_KEY_ENCRYPTED etc. AES256 is chosen since it's supported by Helm templates and is quite generic.

Use case/motivation

The goal is to better support deploying manifests with ArgoCD or similar, where the manifests are stored in Git and thus can't contain secret values due to security reasons. Encrypted values can be stored though, so only the encryption key itself would have to be fetched from a secret, significantly reducing the operational overhead.

Related issues

#45171

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@andrii-korotkov-verkada andrii-korotkov-verkada added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Dec 24, 2024
@dosubot dosubot bot added the area:secrets label Dec 24, 2024
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 24, 2024
Implements support for `_ENCRYPTED` versions of env variables and `_encrypted` versions of config params.
Those would be encrypted using a parameter `params_encryption_aes256_key` (which can be retrieved from a secret for example).
The params encryption key itself doesn't support encrypted suffix, or it'd create an infinite recursion.

closes: apache#45194

Signed-off-by: Andrii Korotkov <[email protected]>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 24, 2024
Implements support for `_ENCRYPTED` versions of env variables and `_encrypted` versions of config params.
Those would be encrypted using a parameter `params_encryption_aes256_key` (which can be retrieved from a secret for example).
The params encryption key itself doesn't support encrypted suffix, or it'd create an infinite recursion.

closes: apache#45194

Signed-off-by: Andrii Korotkov <[email protected]>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/airflow that referenced this issue Dec 24, 2024
Implements support for `_ENCRYPTED` versions of env variables and `_encrypted` versions of config params.
Those would be encrypted using a parameter `params_encryption_aes256_key` (which can be retrieved from a secret for example).
The params encryption key itself doesn't support encrypted suffix, or it'd create an infinite recursion.

closes: apache#45194

Signed-off-by: Andrii Korotkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:secrets kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant