You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you so much for this awesome repository.
I have a question about dependency injection:
You inject MovieDetailsAnimator @Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator
at line 60, MovieDetailsFragment.kt.
And MovieDetailsAnimator is constructed through class MovieDetailsAnimator @Inject constructor()
Wouldn't it be better if MovieDetailsAnimator was constructed with @singleton annotation? Something like: @Singleton class MovieDetailsAnimator @Inject constructor()
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.
Thank you! 👍
The text was updated successfully, but these errors were encountered:
First of all, thank you so much for this awesome repository.
I have a question about dependency injection:
You inject MovieDetailsAnimator
@Inject lateinit var movieDetailsAnimator: MovieDetailsAnimator
at line 60, MovieDetailsFragment.kt.
And MovieDetailsAnimator is constructed through
class MovieDetailsAnimator @Inject constructor()
Wouldn't it be better if MovieDetailsAnimator was constructed with @singleton annotation? Something like:
@Singleton class MovieDetailsAnimator @Inject constructor()
It seems like there is no point on getting a new instance of MovieDetailsAnimator for every fragment.
Thank you! 👍
The text was updated successfully, but these errors were encountered: