Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad temporary thumbnails are being generated #237

Open
cpg opened this issue Aug 14, 2019 · 3 comments
Open

bad temporary thumbnails are being generated #237

cpg opened this issue Aug 14, 2019 · 3 comments

Comments

@cpg
Copy link
Member

cpg commented Aug 14, 2019

When a user goes into a folder with (say) a dozen movies, the thumbnail for some movie that happens to be generated first is used for other movies.

Not sure the order, but some file starting with R got their thumbnail done before one starting with A. The file starting with A has no thumbnail, then .. it surprisingly gets the thumbnail of the file starting with R, which is obviously the wrong thumbnail.

This is not a huge issue, as it appears that the algorithm used here is self-stabilizing, but I'm filing this to

  1. verify that it's self stabilizing and the right thumbnail ends up in the right movie. is it? yes or no?
  2. is it easy to correct this temporary bad assignment of the wrong thumbnail?
@iswiftshek
Copy link
Contributor

I'm not able to reproduce this.
In issue #190, we had the problem of thumbnail regeneration which also caused the disappearance of thumbnails on scrolling, but seems like it's working fine now (thumbnails.
I tested: a folder containing 50+ images, a folder containing 20+ songs, a folder containing 15+ videos & a folder containing several file types.

@Marton-Zeisler could you check and see if you're able to reproduce this behavior?

@Marton-Zeisler
Copy link
Contributor

I was testing the app too but couldn't see this bug yet.

@vaibhavbisht06
Copy link
Contributor

I have tested this app on two different devices.
That folder contained 23 images and 10 songs in one folder. I think this issue is resolved by the Pull request made by @iswiftshek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants