Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest release is full of mismatched types errors. #2

Open
victor7543 opened this issue Feb 23, 2024 · 4 comments
Open

The latest release is full of mismatched types errors. #2

victor7543 opened this issue Feb 23, 2024 · 4 comments

Comments

@victor7543
Copy link

25 errors where the compiler says: expected USize64, found u32. In file src\collectors\gltf.rs.

@amPerl
Copy link
Owner

amPerl commented Feb 23, 2024

Thanks for the report. I must've missed this while testing without default features.

I think the collectors module can go, actually. I find myself updating them too often to fit the purposes of whatever app I'm writing. I don't think any of that should actually be part of this crate.

I'll put up a release that removes them and bumps the other deps soon.

@victor7543
Copy link
Author

victor7543 commented Feb 24, 2024

No problem! Just to add some thoughts about the collectors module from the time I had to look into it, I think the gltf conversion can be useful when working with Bevy, since it's the file format it supports, and I thought the Mesh struct seems to provides a convenient way to interact with the data, so to me at least it seems like a useful module, but I guess in the end it depends on what you are working on. Having to change it all the time does seem like a pain. Great to hear you will put up a new release though, thanks.

@amPerl
Copy link
Owner

amPerl commented Feb 25, 2024

I did actually have an asset plugin for bevy:
image
But I was frustrated that I couldn't specify dependencies on external resources like textures properly, so I stopped before I stuffed too many features into it. Now with the asset system upgrades that's actually possible, I might revisit it.

I think the ergonomics of this crate could be much better. I wrote this when I was dying to get stuff done fast, but I'd really like it to support a much wider version range. Writing nifs back to file is also doable. Shouldn't be too much to add on top of what's here now, but I haven't considered how versioning would work in this context.

@victor7543
Copy link
Author

It's pretty nice that you were able to get this far in earlier versions of Bevy. I think you could probably take some inspiration from C++ libraries that provide similar functionality, like Nifly and Niflib, at least for how to make the versioning work, and I think there is also a python library that offer nice ergonomics, if I am not mistaken. Even if their solutions wouldn't quite fit well in this project, they could give you some nice ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants