From 05d9875a6f18cecb0539c9c17e9f161eb63196c0 Mon Sep 17 00:00:00 2001 From: iFatRain Date: Thu, 25 May 2023 18:07:54 -0500 Subject: [PATCH 1/6] Allows for non-primary test failure to be configured to not show, retains default behavior --- .../io/qameta/allure/testng/AllureTestNg.java | 34 ++++++++++--------- .../testng/config/AllureTestNgConfig.java | 13 +++++++ .../allure/testng/AllureTestNgTest.java | 12 ++++++- 3 files changed, 42 insertions(+), 17 deletions(-) diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java index 5c5e974ae..c9700f230 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java @@ -537,23 +537,25 @@ public void onConfigurationSuccess(final ITestResult itr) { @Override public void onConfigurationFailure(final ITestResult itr) { - final String uuid = UUID.randomUUID().toString(); - final String parentUuid = UUID.randomUUID().toString(); - - startTestCase(itr, parentUuid, uuid); - - addChildToContainer(getUniqueUuid(itr.getTestContext()), uuid); - addChildToContainer(getUniqueUuid(itr.getTestContext().getSuite()), uuid); - addClassContainerChild(itr.getMethod().getTestClass(), uuid); - // results created for configuration failure should not be considered as test cases. - getLifecycle().updateTestCase( - uuid, - tr -> tr.getLabels().add( - new Label().setName(ALLURE_ID_LABEL_NAME).setValue("-1") - ) - ); + if (config.shouldLogConfigurationFailures()) { + final String uuid = UUID.randomUUID().toString(); + final String parentUuid = UUID.randomUUID().toString(); + + startTestCase(itr, parentUuid, uuid); + + addChildToContainer(getUniqueUuid(itr.getTestContext()), uuid); + addChildToContainer(getUniqueUuid(itr.getTestContext().getSuite()), uuid); + addClassContainerChild(itr.getMethod().getTestClass(), uuid); + // results created for configuration failure should not be considered as test cases. + getLifecycle().updateTestCase( + uuid, + tr -> tr.getLabels().add( + new Label().setName(ALLURE_ID_LABEL_NAME).setValue("-1") + ) + ); - stopTestCase(uuid, itr.getThrowable(), getStatus(itr.getThrowable())); + stopTestCase(uuid, itr.getThrowable(), getStatus(itr.getThrowable())); + } //do nothing } diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java b/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java index d4ab05e74..76e288d16 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java @@ -24,10 +24,14 @@ public class AllureTestNgConfig { public static final String ALLURE_TESTNG_HIDE_DISABLED_TESTS = "allure.testng.hide.disabled.tests"; + public static final String ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES = "allure.testng.log.configuration.failures"; private boolean hideDisabledTests; + private boolean logConfigurationFailures; public AllureTestNgConfig(final Properties properties) { this.hideDisabledTests = parseBoolean(properties.getProperty(ALLURE_TESTNG_HIDE_DISABLED_TESTS)); + this.logConfigurationFailures = parseBoolean(properties.getProperty(ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES, + "true")); } public boolean isHideDisabledTests() { @@ -39,6 +43,15 @@ public AllureTestNgConfig setHideDisabledTests(final boolean hide) { return this; } + public boolean shouldLogConfigurationFailures() { + return logConfigurationFailures; + } + + public AllureTestNgConfig setLogConfigurationFailures(final boolean logConfigurationFailure) { + this.logConfigurationFailures = logConfigurationFailure; + return this; + } + public static AllureTestNgConfig loadConfigProperties() { final Properties properties = PropertiesUtils.loadAllureProperties(); return new AllureTestNgConfig(properties); diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java index e3bda742b..aef580983 100644 --- a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java +++ b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java @@ -109,6 +109,16 @@ public static Object[][] parallelConfiguration() { }; } + @AllureFeatures.Fixtures + @Issue("356") + @Test + public void shouldUnsetLogConfigFailProperty() { + AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); + assertThat(allureTestNgConfig.shouldLogConfigurationFailures()).isTrue(); + allureTestNgConfig.setLogConfigurationFailures(false); + assertThat(allureTestNgConfig.shouldLogConfigurationFailures()).isFalse(); + } + @Test public void shouldSetConfigurationProperty() { AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); @@ -974,7 +984,7 @@ public void shouldUseFixtureDescriptions() { @AllureFeatures.Descriptions @Issue("106") - @Test + public void shouldProcessCyrillicDescriptions() { final AllureResults results = runTestNgSuites("suites/gh-106.xml"); From 09a2aa1fb52ec4431e66990e069ae722f0905d72 Mon Sep 17 00:00:00 2001 From: iFatRain Date: Thu, 25 May 2023 18:10:03 -0500 Subject: [PATCH 2/6] Didn't mean to remove this @Test annotation, whoops --- .../src/test/java/io/qameta/allure/testng/AllureTestNgTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java index aef580983..3501eb94a 100644 --- a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java +++ b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java @@ -984,7 +984,7 @@ public void shouldUseFixtureDescriptions() { @AllureFeatures.Descriptions @Issue("106") - + @Test public void shouldProcessCyrillicDescriptions() { final AllureResults results = runTestNgSuites("suites/gh-106.xml"); From 06d100179200a1106d51ef0c5895865a9b6c8ba7 Mon Sep 17 00:00:00 2001 From: iFatRain Date: Fri, 2 Jun 2023 09:17:04 -0500 Subject: [PATCH 3/6] Changing verbiage from should -> is, adding additional unit test for new setting --- .../io/qameta/allure/testng/AllureTestNg.java | 2 +- .../testng/config/AllureTestNgConfig.java | 2 +- .../qameta/allure/testng/AllureTestNgTest.java | 17 +++++++++++++++-- 3 files changed, 17 insertions(+), 4 deletions(-) diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java index c9700f230..177338f9f 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java @@ -537,7 +537,7 @@ public void onConfigurationSuccess(final ITestResult itr) { @Override public void onConfigurationFailure(final ITestResult itr) { - if (config.shouldLogConfigurationFailures()) { + if (config.isLogConfigurationFailures()) { final String uuid = UUID.randomUUID().toString(); final String parentUuid = UUID.randomUUID().toString(); diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java b/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java index 76e288d16..ea45f436e 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java @@ -43,7 +43,7 @@ public AllureTestNgConfig setHideDisabledTests(final boolean hide) { return this; } - public boolean shouldLogConfigurationFailures() { + public boolean isLogConfigurationFailures() { return logConfigurationFailures; } diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java index 3501eb94a..6a3606f20 100644 --- a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java +++ b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java @@ -61,6 +61,7 @@ import java.util.stream.Collectors; import static io.qameta.allure.testng.config.AllureTestNgConfig.ALLURE_TESTNG_HIDE_DISABLED_TESTS; +import static io.qameta.allure.testng.config.AllureTestNgConfig.ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES; import static io.qameta.allure.util.ResultsUtils.ALLURE_SEPARATE_LINES_SYSPROP; import static java.lang.String.format; import static java.util.Arrays.asList; @@ -114,9 +115,21 @@ public static Object[][] parallelConfiguration() { @Test public void shouldUnsetLogConfigFailProperty() { AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); - assertThat(allureTestNgConfig.shouldLogConfigurationFailures()).isTrue(); + assertThat(allureTestNgConfig.isLogConfigurationFailures()).isTrue(); allureTestNgConfig.setLogConfigurationFailures(false); - assertThat(allureTestNgConfig.shouldLogConfigurationFailures()).isFalse(); + assertThat(allureTestNgConfig.isLogConfigurationFailures()).isFalse(); + } + + @AllureFeatures.Fixtures + @Issue("356") + @Test + public void shouldNotDisplayConfigurationFailsAsTests() { + System.setProperty(ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES, "false"); + final AllureResults results = runTestNgSuites("suites/gh-135.xml"); + assertThat(results.getTestResults()) + .extracting(TestResult::getName, TestResult::getStatus) + .containsOnly(tuple("someTest", Status.SKIPPED)); + System.setProperty(ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES, "true"); } @Test From f93a589643a9ddd552abdea155f26c634e16048c Mon Sep 17 00:00:00 2001 From: iFatRain Date: Wed, 21 Jun 2023 11:08:13 -0500 Subject: [PATCH 4/6] Removing Sys.setProp for config related features, adding constructors/overloads to intake a config setting for tests --- .../io/qameta/allure/testng/AllureTestNg.java | 50 ++++++++++++------- .../allure/testng/AllureTestNgTest.java | 42 ++++++++++------ 2 files changed, 58 insertions(+), 34 deletions(-) diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java index 177338f9f..58408bf29 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java @@ -141,6 +141,17 @@ public class AllureTestNg implements private final AllureTestNgConfig config; + /** + * Package private constructor to allow custom configurations for unit tests. + */ + AllureTestNg(final AllureLifecycle lifecycle, + final AllureTestNgTestFilter testFilter, + final AllureTestNgConfig config) { + this.lifecycle = lifecycle; + this.testFilter = testFilter; + this.config = config; + } + public AllureTestNg(final AllureLifecycle lifecycle, final AllureTestNgTestFilter testFilter) { this.lifecycle = lifecycle; @@ -537,26 +548,27 @@ public void onConfigurationSuccess(final ITestResult itr) { @Override public void onConfigurationFailure(final ITestResult itr) { - if (config.isLogConfigurationFailures()) { - final String uuid = UUID.randomUUID().toString(); - final String parentUuid = UUID.randomUUID().toString(); - - startTestCase(itr, parentUuid, uuid); - - addChildToContainer(getUniqueUuid(itr.getTestContext()), uuid); - addChildToContainer(getUniqueUuid(itr.getTestContext().getSuite()), uuid); - addClassContainerChild(itr.getMethod().getTestClass(), uuid); - // results created for configuration failure should not be considered as test cases. - getLifecycle().updateTestCase( - uuid, - tr -> tr.getLabels().add( - new Label().setName(ALLURE_ID_LABEL_NAME).setValue("-1") - ) - ); - - stopTestCase(uuid, itr.getThrowable(), getStatus(itr.getThrowable())); + if (!config.isLogConfigurationFailures()) { + return; //do nothing } - //do nothing + + final String uuid = UUID.randomUUID().toString(); + final String parentUuid = UUID.randomUUID().toString(); + + startTestCase(itr, parentUuid, uuid); + + addChildToContainer(getUniqueUuid(itr.getTestContext()), uuid); + addChildToContainer(getUniqueUuid(itr.getTestContext().getSuite()), uuid); + addClassContainerChild(itr.getMethod().getTestClass(), uuid); + // results created for configuration failure should not be considered as test cases. + getLifecycle().updateTestCase( + uuid, + tr -> tr.getLabels().add( + new Label().setName(ALLURE_ID_LABEL_NAME).setValue("-1") + ) + ); + + stopTestCase(uuid, itr.getThrowable(), getStatus(itr.getThrowable())); } @Override diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java index 6a3606f20..d2c22fea0 100644 --- a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java +++ b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java @@ -60,8 +60,6 @@ import java.util.function.Predicate; import java.util.stream.Collectors; -import static io.qameta.allure.testng.config.AllureTestNgConfig.ALLURE_TESTNG_HIDE_DISABLED_TESTS; -import static io.qameta.allure.testng.config.AllureTestNgConfig.ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES; import static io.qameta.allure.util.ResultsUtils.ALLURE_SEPARATE_LINES_SYSPROP; import static java.lang.String.format; import static java.util.Arrays.asList; @@ -124,12 +122,12 @@ public void shouldUnsetLogConfigFailProperty() { @Issue("356") @Test public void shouldNotDisplayConfigurationFailsAsTests() { - System.setProperty(ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES, "false"); - final AllureResults results = runTestNgSuites("suites/gh-135.xml"); + AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); + allureTestNgConfig.setLogConfigurationFailures(false); + final AllureResults results = runTestNgSuites(allureTestNgConfig, "suites/gh-135.xml"); assertThat(results.getTestResults()) .extracting(TestResult::getName, TestResult::getStatus) .containsOnly(tuple("someTest", Status.SKIPPED)); - System.setProperty(ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES, "true"); } @Test @@ -1106,12 +1104,12 @@ public void shouldDisplayDisabledTests() { @Issue("369") @Test public void shouldNotDisplayDisabledTests() { - System.setProperty(ALLURE_TESTNG_HIDE_DISABLED_TESTS, "true"); - final AllureResults results = runTestNgSuites("suites/gh-369.xml"); + AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); + allureTestNgConfig.setHideDisabledTests(true); + final AllureResults results = runTestNgSuites(allureTestNgConfig,"suites/gh-369.xml"); assertThat(results.getTestResults()) .extracting(TestResult::getName, TestResult::getStatus) .containsOnly(tuple("enabled", Status.PASSED)); - System.setProperty(ALLURE_TESTNG_HIDE_DISABLED_TESTS, "false"); } @SuppressWarnings("unchecked") @@ -1187,12 +1185,6 @@ public void shouldOverrideParameters() { ); } - private AllureResults runTestNgSuites(final String... suites) { - final Consumer emptyConfigurer = testNg -> { - }; - return runTestNgSuites(emptyConfigurer, suites); - } - @SuppressWarnings("unchecked") @AllureFeatures.Parameters @Issue("141") @@ -1248,8 +1240,26 @@ public void shouldOrderTests() { .containsExactly("zTest", "yTest", "xTest", "wTest", "vTest", "vTest"); } + private AllureResults runTestNgSuites(final String... suites) { + final Consumer emptyConfigurer = testNg -> { + }; + return runTestNgSuites(emptyConfigurer, suites); + } + + private AllureResults runTestNgSuites(AllureTestNgConfig config, final String... suites) { + final Consumer emptyConfigurer = testNg -> { + }; + return runTestNgSuites(emptyConfigurer, config, suites); + } + + private AllureResults runTestNgSuites(final Consumer configurer, + final String... suites) {; + return runTestNgSuites(configurer, AllureTestNgConfig.loadConfigProperties(), suites); + } + @Step("Run testng suites {suites}") private AllureResults runTestNgSuites(final Consumer configurer, + final AllureTestNgConfig config, final String... suites) { final ClassLoader classLoader = getClass().getClassLoader(); List suiteFiles = Arrays.stream(suites) @@ -1264,7 +1274,9 @@ private AllureResults runTestNgSuites(final Consumer configurer, final AllureResultsWriterStub results = new AllureResultsWriterStub(); final AllureLifecycle lifecycle = new AllureLifecycle(results); - final AllureTestNg adapter = new AllureTestNg(lifecycle); + final AllureTestNg adapter = new AllureTestNg(lifecycle, + new AllureTestNgTestFilter(), + config); final TestNG testNg = new TestNG(false); testNg.addListener((ITestNGListener) adapter); testNg.setTestSuites(suiteFiles); From da007111deb45096c9dfb146d249c2a3e5a14f20 Mon Sep 17 00:00:00 2001 From: iFatRain Date: Tue, 27 Jun 2023 20:41:32 -0500 Subject: [PATCH 5/6] Changing to default False and log->hide for configuration failure property --- .../io/qameta/allure/testng/AllureTestNg.java | 5 +++-- .../testng/config/AllureTestNgConfig.java | 17 +++++++++-------- .../qameta/allure/testng/AllureTestNgTest.java | 8 ++++---- 3 files changed, 16 insertions(+), 14 deletions(-) diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java index 58408bf29..4cb9afa0d 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/AllureTestNg.java @@ -101,7 +101,8 @@ */ @SuppressWarnings({ "PMD.ExcessiveImports", "PMD.TooManyMethods", "PMD.GodClass", "PMD.CyclomaticComplexity", - "ClassFanOutComplexity", "ClassDataAbstractionCoupling", "PMD.ExcessiveClassLength" + "ClassFanOutComplexity", "ClassDataAbstractionCoupling", "PMD.ExcessiveClassLength", + "PMD.NcssCount" }) public class AllureTestNg implements ISuiteListener, @@ -548,7 +549,7 @@ public void onConfigurationSuccess(final ITestResult itr) { @Override public void onConfigurationFailure(final ITestResult itr) { - if (!config.isLogConfigurationFailures()) { + if (config.isHideConfigurationFailures()) { return; //do nothing } diff --git a/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java b/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java index ea45f436e..f35fdea72 100644 --- a/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java +++ b/allure-testng/src/main/java/io/qameta/allure/testng/config/AllureTestNgConfig.java @@ -24,14 +24,15 @@ public class AllureTestNgConfig { public static final String ALLURE_TESTNG_HIDE_DISABLED_TESTS = "allure.testng.hide.disabled.tests"; - public static final String ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES = "allure.testng.log.configuration.failures"; + public static final String ALLURE_TESTNG_HIDE_CONFIGURATION_FAILURES = "allure.testng.hide.configuration.failures"; private boolean hideDisabledTests; - private boolean logConfigurationFailures; + private boolean hideConfigurationFailures; public AllureTestNgConfig(final Properties properties) { this.hideDisabledTests = parseBoolean(properties.getProperty(ALLURE_TESTNG_HIDE_DISABLED_TESTS)); - this.logConfigurationFailures = parseBoolean(properties.getProperty(ALLURE_TESTNG_LOG_CONFIGURATION_FAILURES, - "true")); + this.hideConfigurationFailures = parseBoolean( + properties.getProperty(ALLURE_TESTNG_HIDE_CONFIGURATION_FAILURES) + ); } public boolean isHideDisabledTests() { @@ -43,12 +44,12 @@ public AllureTestNgConfig setHideDisabledTests(final boolean hide) { return this; } - public boolean isLogConfigurationFailures() { - return logConfigurationFailures; + public boolean isHideConfigurationFailures() { + return hideConfigurationFailures; } - public AllureTestNgConfig setLogConfigurationFailures(final boolean logConfigurationFailure) { - this.logConfigurationFailures = logConfigurationFailure; + public AllureTestNgConfig setHideConfigurationFailures(final boolean hideConfigurationFailure) { + this.hideConfigurationFailures = hideConfigurationFailure; return this; } diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java index d2c22fea0..07a3ceaeb 100644 --- a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java +++ b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java @@ -113,9 +113,9 @@ public static Object[][] parallelConfiguration() { @Test public void shouldUnsetLogConfigFailProperty() { AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); - assertThat(allureTestNgConfig.isLogConfigurationFailures()).isTrue(); - allureTestNgConfig.setLogConfigurationFailures(false); - assertThat(allureTestNgConfig.isLogConfigurationFailures()).isFalse(); + assertThat(allureTestNgConfig.isHideConfigurationFailures()).isFalse(); + allureTestNgConfig.setHideConfigurationFailures(true); + assertThat(allureTestNgConfig.isHideConfigurationFailures()).isTrue(); } @AllureFeatures.Fixtures @@ -123,7 +123,7 @@ public void shouldUnsetLogConfigFailProperty() { @Test public void shouldNotDisplayConfigurationFailsAsTests() { AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); - allureTestNgConfig.setLogConfigurationFailures(false); + allureTestNgConfig.setHideConfigurationFailures(true); final AllureResults results = runTestNgSuites(allureTestNgConfig, "suites/gh-135.xml"); assertThat(results.getTestResults()) .extracting(TestResult::getName, TestResult::getStatus) From a5f6ca9026039c79f5f83ae3a509e34f3559f191 Mon Sep 17 00:00:00 2001 From: iFatRain Date: Tue, 27 Jun 2023 20:46:51 -0500 Subject: [PATCH 6/6] Quick fix of test name to reflect updated naming --- .../src/test/java/io/qameta/allure/testng/AllureTestNgTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java index 07a3ceaeb..69ce4f043 100644 --- a/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java +++ b/allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java @@ -111,7 +111,7 @@ public static Object[][] parallelConfiguration() { @AllureFeatures.Fixtures @Issue("356") @Test - public void shouldUnsetLogConfigFailProperty() { + public void shouldSetHideConfigFailProperty() { AllureTestNgConfig allureTestNgConfig = AllureTestNgConfig.loadConfigProperties(); assertThat(allureTestNgConfig.isHideConfigurationFailures()).isFalse(); allureTestNgConfig.setHideConfigurationFailures(true);