Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Update rubocop to 1.6.2 #207

Open
hjkatz opened this issue Jul 23, 2024 · 2 comments
Open

[bug] Update rubocop to 1.6.2 #207

hjkatz opened this issue Jul 23, 2024 · 2 comments

Comments

@hjkatz
Copy link

hjkatz commented Jul 23, 2024

Release 1.6.1 includes an incorrect autocorrect for rule Layout/SpaceInsideHashLiteralBraces and y'all's recent release to rubygems.org has introduced this for our builds (and possibly others).

See: https://github.com/rubocop/rubocop/releases/tag/v1.62.0

See fix: rubocop/rubocop#12736

Errors look like:


lib/redacted/services/redacted_spec.rb:37:25: C: [Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside empty hash literal braces detected.
--
  | replacements = { ...

...
@pariser
Copy link
Contributor

pariser commented Jul 23, 2024

@hjkatz I'm assuming you mean 1.61.0?

#206 doesn't constrain rubocop to equal 1.61.0; instead we constrain rubocop to be at least 1.61.0. You should be able to bundle update rubocop. This gem won't restrict you from upgrading to 1.62.0!

@hjkatz
Copy link
Author

hjkatz commented Jul 23, 2024

Yes that's right, sorry I mistyped the version.

I'm not super familiar with ruby, and I'll look into the version constraint on our end. For now I at least wanted to report something on the internet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants