Support ASE 3.23 #612
Labels
Milestone
Comments
danielhollas
added
testing
dependencies
danielhollas
added a commit
to danielhollas/aiidalab-widgets-base
that referenced
this issue
Jun 23, 2024
Recently released version ase 3.23 broke one of our tests that hardcodes a binary output from ase.Atoms.write. I opened aiidalab#612 with more details.
danielhollas
added a commit
that referenced
this issue
Jun 23, 2024
Recently released version ase 3.23 broke one of our tests that hardcodes a binary output from ase.Atoms.write. I opened #612 with more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New ASE version 3.23 was released couple weeks ago and represents a big jump since the last version that was released at the end of 2021. One of our unit tests started failing since it hardcodes a binary output from
_StructureDataBaseViewer._prepare_payloadwhich in turn relies onase.Atoms.write.aiidalab-widgets-base/tests/test_viewers.py
Line 79 in df106c5
aiidalab-widgets-base/aiidalab_widgets_base/viewers.py
Line 1093 in df106c5
In #611 I pinned the ase version to unblock CI. We need to verify that the differences are insignificant, and generally verify that the new ASE version did not break anything else that is not covered by tests.
The text was updated successfully, but these errors were encountered: