[Tech debt] Local prefs - migration from metadata prefs

[MatissJanis]

Creating an issue so I don't forget about this.

actual/packages/desktop-client/src/hooks/useLocalPref.ts

Lines 30 to 39 in d0caf9f

	// Migrate from old pref storage location (metadata.json) to local storage
	// eslint-disable-next-line @typescript-eslint/no-explicit-any
	const [metadataPref] = useMetadataPref(prefName as any);
	useEffect(() => {
	if (value !== undefined || metadataPref === undefined) {
	return;
	}
	setValue(metadataPref);
	}, [value, metadataPref, setValue]);

The above code snippet migrates metadata.json prefs to local storage. This works fine (for now). But we will want to remove this logic for v24.11.0 release.

The problem is: metadata.json is never cleaned up. For example: if you had previously set-up a specific budget month - this starting budget month will always be used as the "default". No matter if you open the budget today, tomorrow or a year from now (assuming it's a fresh session with no local storage).

For version v24.11.0 the migration snippet should be removed. We can assume that most people would have auto-magically migrated by then.