Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Show running balance" toggle is not maintained correctly when switching between accounts #3550

Open
2 tasks done
ljrafols opened this issue Oct 3, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@ljrafols
Copy link

ljrafols commented Oct 3, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Context

When toggling the "show running balance" option for a given (first) account, switching to another (second) account causes that second account to have the option enabled as well. However, switching back to the first account will cause the option to disable itself for that first account. The other account will then have the "show running balance" option toggled, but only when switching from the first to the second - switching from a third/another account that does not have "show running balance" toggled to the second one does not invoke this bug

Reproduction Steps

Reproduction steps were done on my local desktop app using the Test Budget file.
This also happens on my Docker-hosted personal budget as well (both client/server upgraded to v24.10.0 released today), reproducible on both the Desktop app and Firefox PWA.

  1. Enabling "show running balance" on Ally Savings
    image

  2. Showing running balance enabled on Ally Savings
    image

  3. Switching to Capital One Checking (this did not have "show running balance" toggled), with balance shown
    image

  4. Switching back to Ally Savings from Capital One Checking, with no running balance shown
    image

  5. Switching to HSBC from Ally Savings, which like Capital One Checking, does not have "show running balance" enabled
    image

  6. Switching back to Capital One Checking from HSBC, where the balance is not shown unlike step 3
    image

Budget file used to reproduce

Sample Budget file:
2024-10-03-Test Budget.zip

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox, Desktop App (Electron)

Operating System

Windows 11

@ljrafols ljrafols added the bug Something isn't working label Oct 3, 2024
@ngocphamm
Copy link

ngocphamm commented Oct 3, 2024

I was going to create a ticket for the "Hide reconciled transactions" toggle with similar behavior but I think those are all related.

This is for the latest version 24.10.0 just released. Docker, Firefox browser.

@MatissJanis
Copy link
Member

Can you check if this PR solved the issue?

#3544

@ngocphamm
Copy link

@MatissJanis Took me a while to figure out how to pull the code, and test, but it looks like the PR fixes both the issue mentioned by @ljrafols and myself.

@ljrafols
Copy link
Author

ljrafols commented Oct 3, 2024

Can you check if this PR solved the issue?

#3544

@MatissJanis This PR does resolve the issue. I wasn't able to replicate the bug with this in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants