Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obvious slow loading of some of the budget info/settings #3524

Open
2 tasks done
youngcw opened this issue Sep 28, 2024 · 2 comments
Open
2 tasks done

Obvious slow loading of some of the budget info/settings #3524

youngcw opened this issue Sep 28, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@youngcw
Copy link
Contributor

youngcw commented Sep 28, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

This isn't really a bug, but at very least its become worse for me lately.

When the budget loads, certain bits of data are correct from the first render, but not all the data/settings are available from the first render. This causes the page to progressively update as that data becomes available. I've attached a screen recording that shows what Im seeing. Its much worse on my phone using my real budget. I think a similar thing is happening on the mobile accounts page where the balances all start at 0 then update after a second or two.

The bits of data/settings that I've seen be affected by this are:
Goal data (goal value and long goal)
Privacy mode
Category Notes

Can these bits of data/settings be made to be available at first render? The category budget, spent and balance fields are, so why not the other bits of info?

I cant seem to get it to happen the demo, so it may have been introduced since the 24.9.0 release.

To recreate:
1.Open the edge build
2. view as many months as you can
3. turn on privacy mode
4. add some notes and or templates (the goal is to add as much data to the screen as possible)
5. refresh the page a few times and watch closely. Sometimes its more noticeable than others.

progressive_load_cut.webm

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

@youngcw youngcw added the bug Something isn't working label Sep 28, 2024
@MatissJanis
Copy link
Member

The move to SyncedPrefs would have caused the privacy mode toggle (and other synced prefs) to appear to be a bit slower. Each time it loads a preference - it performs a separate call to the backend. Individually that's super fast, but if there are hundreds of calls - things can get slow.

There's definitely an optimization we could do here (i.e. fetch all synced prefs and store in redux state; and then just get them from the state instead of backend). I'll look into updating that after the upcoming release.

As for the other things: no immediate ideas.

@youngcw
Copy link
Contributor Author

youngcw commented Oct 2, 2024

A note one this: it looks like, at least the template data, doesn't load until after a sync has finished. I haven't tested this on desktop but that looks to be part of the reason on mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants