Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: rules' "select all" checkbox doesn't know about the filter field #3366

Open
2 tasks done
olets opened this issue Sep 4, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@olets
Copy link
Contributor

olets commented Sep 4, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Scenario: you want to delete all rules which match a certain filter.

Expected: go to Rules, enter something into the filter field, check the checkbox in the table header, and click the delete button. All rules shown in the filtered view are deleted.

Current: go to Rules, enter something into the filter field, check the checkbox in the table header, and click the delete button. All rules are deleted, including rules the user did not want to delete.

The delete button's text does reflect the current behavior, so when the user is paying close attention and the count difference is obvious (e.g. two filtered rules are in the view, and the button says "delete 200 rules") the current behavior is okay. If the user is not paying close attention, or the count difference is not obvious, it's problematic.

If the current behavior is intentional, it would be nice to add a confirmation modal when clicking the delete button on filtered rules views.

Happens on desktop and web.

Where are you hosting Actual?

N/A

What browsers are you seeing the problem on?

I've tested Chrome and Firefox. But it should not be browser-dependent.

Operating System

Mac OSX

@olets olets added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant