Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More than 1 subchart (deps) are ignored #91

Open
BigForNothing opened this issue Aug 13, 2024 · 3 comments · Fixed by #97
Open

More than 1 subchart (deps) are ignored #91

BigForNothing opened this issue Aug 13, 2024 · 3 comments · Fixed by #97
Labels
bug Something isn't working

Comments

@BigForNothing
Copy link

I tried to get a helm chart to build with subcharts, but there doesn't seem to be a way to get that to work. I tried to use the deps option of helm_package, and that works but only for one dep. If I specify two or more, only the most recent chart is included. The one chart that is included, everything is proper.

  • I'm not sure if the chart.metadata.json is supposed to list anything about the subcharts, but it does not.
  • the deps_manifest.json does list all the charts

I think this is a bug in the deps handling

@abrisco
Copy link
Owner

abrisco commented Aug 14, 2024

That would definitely be a bug! I'd be happy to review a PR to fix it 😄

@abrisco abrisco added the bug Something isn't working label Aug 14, 2024
@abrisco abrisco changed the title Subcharts More than 1 subchart (deps) are ignored Sep 7, 2024
@abrisco abrisco reopened this Sep 25, 2024
@abrisco
Copy link
Owner

abrisco commented Sep 25, 2024

I added some tests in #97 which shows dependencies are working correctly, one thing that could be improved is that adding something to the deps attribute still requires you to add the dependency to your Chart.yaml. The rules should probably be updated to error if these two lists are not in sync. Can you double check your Chart.yaml is up to date?

@purkhusid
Copy link

This happens when you have dependencies that have the same target name. E.g.

helm_package(
    deps = ["//a/b/c:yo", "//x/y/z:yo"]
)

This is fixed in #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants