Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Store publication issues when using Carthage #698

Closed
makoni opened this issue Feb 22, 2018 · 22 comments
Closed

App Store publication issues when using Carthage #698

makoni opened this issue Feb 22, 2018 · 22 comments
Assignees
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@makoni
Copy link

makoni commented Feb 22, 2018

There're few issues with publishing to App Store if you add Ably through.

Tha app builds and runs but when you're making an archive and upload it to App Store it won't be validated. Errors while validating:

iTunes Store Operation Failed
CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.facebook.socketrocket.ios' under the iOS application 'myApp.app'.

iTunes Store Operation Failed
CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'com.remyvirin.msgpack' under the iOS application 'myApp.app'.

iTunes Store Operation Failed
CFBundleIdentifier Collision. There is more than one bundle with the CFBundleIdentifier value 'org.stenerud.KSCrash' under the iOS application 'myApp.app'.

iTunes Store Operation Failed
This bundle Payload/myApp.app/Frameworks/Ably.framework/Frameworks/SocketRocket.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

iTunes Store Operation Failed
This bundle Payload/myApp.app/Frameworks/SocketRocket.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

iTunes Store Operation Failed
Invalid Bundle. The bundle at 'myApp.app/Frameworks/Ably.framework' contains disallowed nested bundles.

iTunes Store Operation Failed
Invalid Bundle. The bundle at 'myApp.app/Frameworks/Ably.framework' contains disallowed file 'Frameworks'.

Is there a chance in will be fixed?

Here's how signing screen looks like:
2018-02-22 16 05 57

@funkyboy
Copy link
Contributor

@makoni Thanks for reporting this.
Which version of the SDK are you using?

@makoni
Copy link
Author

makoni commented Feb 22, 2018

I use latest Xcode 9.2 with iOS 11 SDK

@funkyboy
Copy link
Contributor

@makoni That's also good to know.

I was asking about the version of the Ably SDK :)
What's your Cartfile like?

@makoni
Copy link
Author

makoni commented Feb 22, 2018

github "ably/ably-ios" == 1.0.11

I had the same issues with github "ably/ably-ios" ~> 1.0

@funkyboy
Copy link
Contributor

Thanks. What version of Carthage are you using? (carthage version in the terminal)

@makoni
Copy link
Author

makoni commented Feb 22, 2018

0.28.0

@funkyboy
Copy link
Contributor

Is your app including an App Extension by chance?

@makoni
Copy link
Author

makoni commented Feb 22, 2018

No, just iOS app without extensions

@makoni
Copy link
Author

makoni commented Feb 22, 2018

Here's how my Carthage build folder looks like if it can help:

2018-02-22 17 20 07

@funkyboy
Copy link
Contributor

funkyboy commented Feb 22, 2018

There's a duplication on the file system but likely there's also one in the Xcode project.

In the General tab what's "Linked Frameworks and Libraries" like?

@makoni
Copy link
Author

makoni commented Feb 22, 2018

@funkyboy
Copy link
Contributor

Can you please get rid of the Carthage build folder and anything related to Carthage in the project, and then run carthage update --no-use-binaries?

@makoni
Copy link
Author

makoni commented Feb 22, 2018

I made an empty Xcode project which you can use to reproduce all issues. Just change bundle id and team to yours and try to archive and validate:

ablyTest.zip

@funkyboy
Copy link
Contributor

Will try now. Thanks.

@funkyboy
Copy link
Contributor

@makoni The solution (workaround?) I found is to delete this folder.
screen shot 2018-02-22 at 16 03 05

Not ideal, but at least you can submit your app :)
Will keep this issue open because it needs investigation.

Thanks for your help so far!

@funkyboy
Copy link
Contributor

If you hit the SocketRocket missing CFBundleVersion value just add this to the SocketRocket Info.plist.
screen shot 2018-02-22 at 16 12 18

@funkyboy funkyboy self-assigned this Feb 22, 2018
@funkyboy funkyboy changed the title Carthage usage: App Store publication issues App Store publication issues when using Carthage Feb 26, 2018
@funkyboy funkyboy added bug Something isn't working. It's clear that this does need to be fixed. and removed needs_investigation labels Feb 26, 2018
@funkyboy
Copy link
Contributor

funkyboy commented Feb 26, 2018

As for the SocketRocket error I sent a PR here: facebookincubator/SocketRocket#559

@funkyboy
Copy link
Contributor

I created a separate issue for the "SocketRocket missing CFBundleVersion" problem here

@funkyboy
Copy link
Contributor

@makoni This is now fixed in version 1.0.12

@bhargavbajani
Copy link

bhargavbajani commented Dec 6, 2022

@funkyboy
A duplicate framework issue is happening in latest version >= 1.2.16

image

@bhargavbajani
Copy link

@makoni can you reopen this?

@makoni
Copy link
Author

makoni commented Dec 7, 2022

@makoni can you reopen this?

Unfortunately there's no reopen button. Try to open a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

3 participants