Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DB/SQL support #16

Open
Saqibm128 opened this issue Oct 22, 2017 · 3 comments
Open

Add DB/SQL support #16

Saqibm128 opened this issue Oct 22, 2017 · 3 comments

Comments

@Saqibm128
Copy link
Contributor

Is there a way to support the reading of data directly from a database instead of from csv files? Our lab hosts MIMIC3 data in an SQL database, so it would be very helpful for us.

Perhaps some optional argument that takes in key information to set up the connection, which could be passed in to functions in mimic3csv.py? Or maybe some kind of check for a global config file that sets up connection to MIMIC3 database?

I assume that the dataframe returned from the CSV would be the same as the dataframe from a pd.read_sql("SELECT * FROM ", connection)?

@turambar
Copy link
Collaborator

@Saqibm128 it looks like pandas has support for reading the results of a SQL query into a DataFrame, so that should be doable: http://pandas.pydata.org/pandas-docs/version/0.20/generated/pandas.read_sql.html.

That said, we don't have the bandwidth to implement this ourselves (expanding the benchmark to include other variables, treatments, etc., are higher priorities). We would happily accept a pull request, however!

This was referenced Oct 29, 2017
Closed
@turambar
Copy link
Collaborator

Related to PR currently under review: #22

@turambar turambar self-assigned this Jan 16, 2018
@turambar
Copy link
Collaborator

We should make this merge now that the 1.0 release is done. @Harhro94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants