Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send all changes of fork to official SDL Mixer #8

Open
2 of 5 tasks
Wohlstand opened this issue Jan 16, 2018 · 4 comments
Open
2 of 5 tasks

Send all changes of fork to official SDL Mixer #8

Wohlstand opened this issue Jan 16, 2018 · 4 comments
Assignees

Comments

@Wohlstand
Copy link
Member

Wohlstand commented Jan 16, 2018

All changes made on this fork are will be useful on original SDL Mixer too. Changes are must be applied accurate and result must be build-able through same set of toolchains as supported on original SDL Mixer

Todo

  • Main part (Features, improvements)
  • Customized libID3Tag library into "external" folder with revived autotools support (which was dropped away) Replaced with own code to parse ID3 and other tags in MP3 files
  • Autotools build support for GME, ADLMIDI, and OPNMIDI No needed at all, SDL3 drops away the autotools support.
  • New audio codecs (GME, ADLMIDI, OPNMIDI) into "external" folder
  • Mix_InitMixer(), Mix_FreeMixer(), and callback retrievers
  • Multi-Music system and new *Stream* calls

Stuff

Toolchains

  • Automake
  • Visual Studio projects of various versions
  • XCode project(s)
@Wohlstand Wohlstand self-assigned this Jan 16, 2018
@Wohlstand
Copy link
Member Author

First part of changes has been sent as pull-request except of GME, ADLMIDI and OPNMIDI support, and libID3Tag library itself as that requires to add them into "external" subfolder and provide support for autotools build.

@vilhelmgray
Copy link

I suspect you're more likely to get a response if you submit a message to the SDL Development mailing list: https://discourse.libsdl.org/t/about-the-sdl-development-category/13

It looks like the bugzilla is primarily for bug tracking, but since you are trying to merge in many new features, your pull request may have better luck in the SDL Development mailing list.

I'd really like to see these improvements in SDL Mixer X merged back into the SDL Mixer project since your changes look very useful, and I'm hoping the SDL developers will also agree. :-)

@Wohlstand
Copy link
Member Author

Wohlstand commented Nov 27, 2019

A todo list from the earlier random discussion:
29a9e82#commitcomment-36157497

  • GUTS: most bug and warning fixes made in MixerX
  • FORMATS: extending of WAV parser (I have polished it to support much more WAV formats which wasn't supported good). Looks like I'll port this now, it can be backported now
  • GUTS: extending of Mix_MusicInterface with new calls
  • API: Ability to set custom patches path for Timidity (for example, allow game developer to pick-up own bank with a game and don't rely on these are installed in the system).
  • API & GUTS: ability to switch MIDI device in real time (will add new API calls), adding support of path arguments to allow select the MIDI library by using of |sX; tail.
  • API: meta-tags
  • API: more music related calls
  • API: more SFX related calls (mainly Mix_PlayChanTimedVolume() to solve one of oldest problems when we usually getting old volume value of channel and we can't tell which volume we want to play, mainly, when we using -1 for automatical look up of the channel index)
  • API + GUTS: this Add ability to initialize and use the mixer without it taking over the SDL audio callback #20
  • FORMATS & API: Adding a support for more format libraries (ADLMIDI, OPNMIDI, GME and XMP), adding specific API to allow tuning of every of these libraries

@Wohlstand
Copy link
Member Author

Wohlstand commented Nov 27, 2019

@vilhelmgray, after time of waiting, Sam Lantinga has finally replied on my post I have submitted on SDL's bugzilla. So, right now I working on a submitting of patches to Mixer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants