-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWiki page based translation are serialized with a white space in front of the ending </xwikidoc> #11896
Comments
Related unit test to fix: https://github.com/WeblateOrg/weblate/blob/main/weblate/trans/tests/data/XWikiPageProperties.xml#L52 |
@nijel you can assign that one to me. |
* Ensure to clean up node after performing operation on the XML * Fix existing tests See: WeblateOrg/weblate#11896
* Fix added spaces in XWikiPageProperties format XML output * Ensure to clean up node after performing operation on the XML * Fix existing tests See: WeblateOrg/weblate#11896
The issue you've reported needs to be addressed in the translate-toolkit. Please file the issue there, and include links to any relevant specifications about the formats (if applicable). |
I guess that fix in translate/translate#5269 is sufficient, closing this issue now. It now needs a translate-toolkit release to be used by Weblate (which will take some time because one release was this week). |
Thank you for your report; the issue you have reported has just been fixed.
|
To be checked but I think https://github.com/WeblateOrg/weblate/blob/main/weblate/trans/tests/data/XWikiPageProperties.xml#L52 needs to be fixed too: you'll probably get test failures right now. |
That is used for parsing only (at list this is the case for other formats), so that should be fine. |
Describe the issue
When a new translation is committed, it contains a strange white space in front of the ending
</xwikidoc>
. It's a bit annoying since it cause xar:format to produce unexpected changes when it's executed later on the project.I already tried
Steps to reproduce the behavior
Start translating a new locale.
Expected behavior
Not having a white space in front of the ending
</xwikidoc>
.Screenshots
https://github.com/xwiki/xwiki-platform/pull/3211/files#diff-f1232b93d79779d15c266e620853c554c767cb58a680f03a14e7c91b61724465R139
Exception traceback
No response
How do you run Weblate?
PyPI module
Weblate versions
No response
Weblate deploy checks
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: