Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline search bar allows line breaks #10816

Closed
2 tasks done
Cerno-b opened this issue Jan 19, 2024 · 1 comment
Closed
2 tasks done

Multiline search bar allows line breaks #10816

Cerno-b opened this issue Jan 19, 2024 · 1 comment
Assignees
Labels
bug Something is broken.
Milestone

Comments

@Cerno-b
Copy link

Cerno-b commented Jan 19, 2024

Describe the issue

The new multiline search bar allows line breaks when copy/pasting text. This is new behavior which is reducing UX.

Old behavior: Pasting a string with a line break at the end would delete the line break
New behavior: Pasting a string with a line break at the end is kept in the search and leads to a missed search result.

Example:
https://hosted.weblate.org/projects/godot-engine/godot-docs/de/?q=location:docs/tutorials/navigation/navigation_using_navigationlayers%0D%0A#search

Note the %0D%0A in the link, which represents the carriage return and line break character, respectively.

This makes life a little mit more inconvenient, since the search returns no results and the line breaks have to be removed manually.

I believe this is undesired behavior as well, since it is not possible to add manual line breaks in the search (neither via "Enter" nor "Ctrl-Enter").

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Go to https://hosted.weblate.org/projects/godot-engine/godot-docs/de/?q=location:docs/tutorials/navigation/navigation_using_navigationlayers%0D%0A#search
  2. The search should return no results
  3. Remove the line break in the search bar
  4. Press Enter
  5. The search will execute properly

Expected behavior

I would like the search string to be stripped of CARRIAGE_RETURN and LINE_FEED characters on paste. At least at the beginning and end of the string, but probably also anywhere in the middle.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

@nijel nijel self-assigned this Jan 22, 2024
@nijel nijel added the bug Something is broken. label Jan 22, 2024
@nijel nijel added this to the 5.4 milestone Jan 22, 2024
@nijel nijel closed this as completed in cbb8762 Jan 22, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

No branches or pull requests

2 participants