Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taint issue, easily reproducible. #5448

Closed
1 task done
Bodify opened this issue Sep 28, 2024 · 1 comment
Closed
1 task done

Taint issue, easily reproducible. #5448

Bodify opened this issue Sep 28, 2024 · 1 comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@Bodify
Copy link

Bodify commented Sep 28, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Issue:
I’ve been encountering a taint error from WeakAuras occasionally, mainly while switching tabs in the ChatFrame or when receiving a RealID direct message. I first noticed it about two weeks ago, though it’s quite rare.

Reproduction Steps:

  1. Reload UI while in combat.
  2. Send/recieve a direct message (RealID/Battle.net) after the reload completes.

I can also reproduce the error by sending a message through the Battle.net app without opening the Friendlist. I’ve tested this with all addons disabled, including a fresh installation with no WeakAuras, but the issue persists.

Taint Log:

9/28 18:58:56.679  Global variable ChatThrottleLib tainted by WeakAuras - Interface/AddOns/WeakAuras/Libs/AceComm-3.0/ChatThrottleLib.lua:48
9/28 18:58:56.784  Global variable CUF_PROFILE_ACTIVATE_PATCH_VERSION tainted by WeakAuras - Interface/AddOns/WeakAuras/Libs/TaintLess/TaintLess.xml:<Scripts>:32 patch()
9/28 18:58:56.784      Interface/AddOns/WeakAuras/Libs/TaintLess/TaintLess.xml:<Scripts>:64
9/28 18:58:56.784  Global variable WeakAuras tainted by WeakAuras - Interface/AddOns/WeakAuras/Init.lua:7
9/28 18:58:56.939  Global variable WeakAurasProfilingReportMixin tainted by WeakAuras - Interface/AddOns/WeakAuras/Profiling.lua:47
9/28 18:58:56.939  Global variable WeakAurasProfilingLineMixin tainted by WeakAuras - Interface/AddOns/WeakAuras/Profiling.lua:436
9/28 18:58:56.939  Global variable WeakAurasProfilingMixin tainted by WeakAuras - Interface/AddOns/WeakAuras/Profiling.lua:476
9/28 18:58:56.939  Global variable WeakAurasProfilingResultButton_OnClick tainted by WeakAuras - Interface/AddOns/WeakAuras/Profiling.lua:578
9/28 18:58:56.939  Global variable WeakAurasProfilingStopButton_OnClick tainted by WeakAuras - Interface/AddOns/WeakAuras/Profiling.lua:610
9/28 18:58:56.939  Global variable WeakAurasProfilingColumnDisplay_OnClick tainted by WeakAuras - Interface/AddOns/WeakAuras/Profiling.lua:828
9/28 18:58:56.958  Global variable WeakAurasTimers tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:34
9/28 18:58:56.958  Global variable SLASH_WEAKAURAS2 tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:187
9/28 18:58:56.958  Global variable SLASH_WEAKAURAS1 tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:187
9/28 18:58:56.958  Global variable BINDING_HEADER_WEAKAURAS tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:270
9/28 18:58:56.958  Global variable BINDING_NAME_WEAKAURASTOGGLE tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:271
9/28 18:58:56.958  Global variable BINDING_NAME_WEAKAURASPROFILINGTOGGLE tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:272
9/28 18:58:56.958  Global variable BINDING_NAME_WEAKAURASPRINTPROFILING tainted by WeakAuras - Interface/AddOns/WeakAuras/WeakAuras.lua:273
9/28 18:58:57.114  Global variable WeakAurasCompanionData tainted by WeakAurasCompanion - Interface/AddOns/WeakAurasCompanion/data.lua:11
9/28 18:58:57.494  Execution tainted by WeakAuras while reading BINDING_HEADER_WEAKAURAS - Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:169
9/28 18:58:57.494      securecallfunction()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:197 CreateKeybindingInitializers()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:270 registrant()
9/28 18:58:57.494      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:15
9/28 18:58:57.494      secureexecuterange()
9/28 18:58:57.494      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:17 callback()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXML/EventUtil.lua:21
9/28 18:58:57.494      securecallfunction()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:144
9/28 18:58:57.494      secureexecuterange()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:147 TriggerEvent()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:9
9/28 18:58:57.494  Execution tainted by WeakAuras while reading BINDING_HEADER_WEAKAURAS - Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:169
9/28 18:58:57.494      securecallfunction()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:197 CreateKeybindingInitializers()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:270 registrant()
9/28 18:58:57.494      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:15
9/28 18:58:57.494      secureexecuterange()
9/28 18:58:57.494      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:17 callback()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXML/EventUtil.lua:21
9/28 18:58:57.494      securecallfunction()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:144
9/28 18:58:57.494      secureexecuterange()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:147 TriggerEvent()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:9
9/28 18:58:57.494  Execution tainted by WeakAuras while reading BINDING_HEADER_WEAKAURAS - Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:169
9/28 18:58:57.494      securecallfunction()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:197 CreateKeybindingInitializers()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:270 registrant()
9/28 18:58:57.494      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:15
9/28 18:58:57.494      secureexecuterange()
9/28 18:58:57.494      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:17 callback()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXML/EventUtil.lua:21
9/28 18:58:57.494      securecallfunction()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:144
9/28 18:58:57.494      secureexecuterange()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:147 TriggerEvent()
9/28 18:58:57.494      Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:9
9/28 18:58:57.500  Execution tainted by WeakAuras while reading BINDING_NAME_WEAKAURASTOGGLE - Interface/AddOns/Blizzard_SharedXML/BindingUtil.lua:143
9/28 18:58:57.500      securecallfunction()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:158 CreateSearchableSettings()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:221 CreateKeybindingInitializers()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:270 registrant()
9/28 18:58:57.500      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:15
9/28 18:58:57.500      secureexecuterange()
9/28 18:58:57.500      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:17 callback()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXML/EventUtil.lua:21
9/28 18:58:57.500      securecallfunction()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:144
9/28 18:58:57.500      secureexecuterange()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:147 TriggerEvent()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:9
9/28 18:58:57.500  Execution tainted by WeakAuras while reading BINDING_NAME_WEAKAURASPROFILINGTOGGLE - Interface/AddOns/Blizzard_SharedXML/BindingUtil.lua:143
9/28 18:58:57.500      securecallfunction()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:158 CreateSearchableSettings()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:221 CreateKeybindingInitializers()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:270 registrant()
9/28 18:58:57.500      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:15
9/28 18:58:57.500      secureexecuterange()
9/28 18:58:57.500      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:17 callback()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXML/EventUtil.lua:21
9/28 18:58:57.500      securecallfunction()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:144
9/28 18:58:57.500      secureexecuterange()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:147 TriggerEvent()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:9
9/28 18:58:57.500  Execution tainted by WeakAuras while reading BINDING_NAME_WEAKAURASPRINTPROFILING - Interface/AddOns/Blizzard_SharedXML/BindingUtil.lua:143
9/28 18:58:57.500      securecallfunction()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:158 CreateSearchableSettings()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:221 CreateKeybindingInitializers()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SettingsDefinitions_Frame/Keybindings.lua:270 registrant()
9/28 18:58:57.500      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:15
9/28 18:58:57.500      secureexecuterange()
9/28 18:58:57.500      Interface/AddOns/Blizzard_Settings_Shared/Blizzard_SettingsRegistrar.lua:17 callback()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXML/EventUtil.lua:21
9/28 18:58:57.500      securecallfunction()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:144
9/28 18:58:57.500      secureexecuterange()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:147 TriggerEvent()
9/28 18:58:57.500      Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:9
9/28 18:59:03.440  Global variable SELECTED_DOCK_FRAME tainted by WeakAuras - Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1347 FCF_SelectDockFrame()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:2370
9/28 18:59:03.440  Interface/AddOns/Blizzard_ChatFrameBase/Mainline/ChatFrame.lua:3789 ChatFrame_MessageEventHandler()
9/28 18:59:03.440  An action was blocked in combat because of taint from WeakAuras - ChatFrame1:Hide()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1876 FCFDock_UpdateTabs()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1848 FCFDock_SelectWindow()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1358 FCF_SelectDockFrame()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:2370
9/28 18:59:03.440  Interface/AddOns/Blizzard_ChatFrameBase/Mainline/ChatFrame.lua:3789 ChatFrame_MessageEventHandler()
9/28 18:59:03.440  An action was blocked in combat because of taint from WeakAuras - ChatFrame1:Hide()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1876 FCFDock_UpdateTabs()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1285 oldFCF_DockUpdate()
9/28 18:59:03.440      Interface/AddOns/Blizzard_CombatLog/Mainline/Blizzard_CombatLog.lua:3353 FCF_DockUpdate()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:1359 FCF_SelectDockFrame()
9/28 18:59:03.440      Interface/AddOns/Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:2370

WeakAuras Version

5.17.1

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

1x [ADDON_ACTION_BLOCKED] AddOn 'WeakAuras' tried to call the protected function 'ChatFrame1:Hide()'.
[string "@!BugGrabber/BugGrabber.lua"]:485: in function <!BugGrabber/BugGrabber.lua:485>
[string "=[C]"]: in function `Hide'
[string "@Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua"]:1876: in function `FCFDock_UpdateTabs'
[string "@Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua"]:1848: in function `FCFDock_SelectWindow'
[string "@Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua"]:1358: in function `FCF_SelectDockFrame'
[string "@Blizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua"]:2370: in function <...lizzard_ChatFrameBase/Mainline/FloatingChatFrame.lua:2347>

Locals:
_ = Frame {
}
event = "ADDON_ACTION_BLOCKED"
events = <table> {
}

Reproduction Steps

  1. Reload UI while in combat
  2. Send/recieve a direct message (RealID/Battle.net) after the reload completes.

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response
@Bodify Bodify added the 🐛 Bug This is a problem with WeakAuras. label Sep 28, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Sep 28, 2024
@InfusOnWoW
Copy link
Contributor

Unfortuantely that very much looks like a issue in blizzard's code.

And I don't want to spent time debugging this in detail for a bug report to them, as most likely that bug report would never be acted on, and thus debugging this would be a huge waste of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@InfusOnWoW @Bodify