Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should LaunchParams.files use FileSystemFileHandle? #87

Open
tomayac opened this issue Dec 15, 2022 · 1 comment
Open

Should LaunchParams.files use FileSystemFileHandle? #87

tomayac opened this issue Dec 15, 2022 · 1 comment

Comments

@tomayac
Copy link
Contributor

tomayac commented Dec 15, 2022

The property is named files, which means no directories, but it uses FileSystemHandle, which includes directories. Should it be more specific and use FileSystemFileHandle instead?
@tomayac tomayac mentioned this issue Dec 15, 2022
Merged
@fallaciousreasoning
Copy link
Collaborator

Alternatively, we could add a new directories property, which might be better as it wouldn't break anything? No strong feelings on this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomayac @fallaciousreasoning