Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Window can be closed with Ctrl+W #934

Open
3 tasks done
SourLemonJuice opened this issue Oct 28, 2024 · 4 comments
Open
3 tasks done

[Bug] Window can be closed with Ctrl+W #934

SourLemonJuice opened this issue Oct 28, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@SourLemonJuice
Copy link

SourLemonJuice commented Oct 28, 2024

Discord Account

No response

Operating System

Arch Linux

Linux Only ~ Desktop Environment

KDE Plasma(Wayland)

Package Type

AUR and Appimage, version 1.5.3

What happens when the bug or crash occurs?

The window closes when I press Ctrl+W, but the official discord client does not.
It happened on any page, whether it's on the login or chat page.

What is the expected behaviour?

Nothing will happen.
Blocking browser shortcut keys shouldn't be that hard, I guess.

How do you recreate this bug or crash?

  1. open a Vesktop window.
  2. press Ctrl+W.

Debug Logs

No new logs have been added, which is a very small thing.

Request Agreement

  • I have searched the existing issues and found no similar issue
  • I am using the latest Vesktop and Vencord versions
  • This issue occurs on an official release (not just the AUR or Nix packages)
@SourLemonJuice SourLemonJuice added the bug Something isn't working label Oct 28, 2024
@yllekz
Copy link

yllekz commented Nov 14, 2024

Is this truly a bug? IMO this should be a standard feature for all apps, and quite often is. on macOS, it's a global system shortcut to CMD + W to close a window, and on Linux Mint, nearly every app I use defaults to this. I don't think it's a bug, and rather, I enjoy that this exists. The fact that the official Discord app doesn't do this sounds like a problem on their end that they should rectify.

@hir0xygen
Copy link

I agree with @yllekz, this definitely isn't a bug and I use this quite a lot.
It's pretty standard in lots of programs, a notable example possibly being the Nemo file explorer.
If this behavior were to be changed, maybe just via a toggle to block browser shortcuts?

@technikker
Copy link

Closing a window/tab/file via the Ctrl-W shortcut is an intentional feature in most apps.

In most cases it is an 'Alt-F4 Lite', which will close the currently opened file (e.g. notepad++) or tab (e.g. firefox), while leaving the app itself running, but some apps where the former case doesn't make sense will simply exit entirely.

@SourLemonJuice
Copy link
Author

SourLemonJuice commented Nov 20, 2024

emm...

Alt+F4 is a system shortcut that is captured by the operating system (or desktop environment) and sends the kill signal to the program. The program itself is not aware of this.

Ctrl+W is a consensus for managing tabs, browsers have tabs so the browser captures and implements them, but Discord will always have one page even though it's essentially a web frontend.
Was the Windows file explorer turned off by Ctrl+W before Win11?

In my case, KDE Plasma is my desktop environment and I define Ctrl+Shift+W more to my liking (copied from ChromeOS).
Window closing shortcuts are a system-wide thing not something individual programs need to be care about, Vesktop just forgot to block browser stuff.

Translated from Deepl and Me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants