-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zooming doesn't work in Safari browser #35
Comments
Does it work on another macOS browser? |
Yes, I asked my colleague, he uses macos catalina and safari version is 14.0. Bug reproduced. |
I meant on a non-safari browser on macOS like Chrome. I tried it kinda work even though it doesn't feel natural. I don't know if there is a way to listen to this gesture on safari. |
Ok this is probably this one that should be handled: https://developer.mozilla.org/en-US/docs/Web/API/Element/gesturechange_event Today, we simply prevent the default. |
I fixed this in the react version a few minutes ago: ValentinH/react-easy-crop#414 Would you be interested in adding the same to this svelte version? I haven't touched Svelte for years 🙈 |
Don't you think that the math of the zooming algorithm is wrong? I don't know why but all versions higher than 4.6.0 can zoom but the destination point is wrong; I mean i get stuck in corner every time i try to zoom center of the image, no matter where and how I pitch on my touchpad zooming always behave like this. Attaching video to show how it works Screen.Recording.2022-10-14.at.22.23.31.mov |
I actually noticed this as well but it's only on codesandbox and using safari if I'm not mistaken. Therefore, it's probably due to iframes and the gesture client X/Y not being correct. I'll have to investigate... So you confirm your video is taken on Safari? |
Yes, the video was taken from safari |
Are you reporting a bug?
Basic example is relevant and bug could be reproduced -> https://codesandbox.io/s/svelte-easy-crop-basic-demo-q1005?file=/App.svelte. Also reproduces on react-easy-crop basic example.
Env:
Provide the steps to reproduce the issue, e.g.:
Expected behaviour
Pinch works correctly in Safari
The text was updated successfully, but these errors were encountered: