Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwipeButton stuck if swiped halfway and scrolled vertically inside scrollview #46

Open
CyberMew opened this issue Sep 8, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@CyberMew
Copy link

CyberMew commented Sep 8, 2020

Describe the bug
SwipeButton stuck if swiped halfway and scrolled vertically inside scrollview.

i.e. if you swipe halfway and then move it up or down, scrollview takes over control, and you cannot continue to swipe the half-swiped thumb anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Put SwipeButton inside a ScrollView.
  2. Test it on iOS.
  3. See bug.

Expected behavior
Scrollview SHOULD NOT take over control.

Additional context
Using 1.2.8 as 1.2.9 and 1.3.0 doesn't support RN 0.61.x.

@UdaySravanK
Copy link
Owner

Hi @CyberMew Thanks for reporting the issue. This is not specific to iOS. Using this component in ScrollView has some issues. I will work on this soon in my free time.

@CyberMew
Copy link
Author

Hi @UdaySravanK, thanks for the information. Hopefully you have had time over the past half year to tinker with this. Do you think there will be a fix anytime soon? Because this is interfering with the user experience as it is very hard to swipe in a scrollview situation and it gets stuck easily. Hope you can let us know so we can make a decision to abandon this library and go for another UX for interacting with the button, or if there is another similar library you can advise that can achieve this?

@UdaySravanK UdaySravanK changed the title SwipeButton stuck if swiped halfway and scrolled vertically inside scrollview Bug: SwipeButton stuck if swiped halfway and scrolled vertically inside scrollview May 20, 2022
@UdaySravanK UdaySravanK added the bug Something isn't working label May 20, 2022
@UdaySravanK UdaySravanK changed the title Bug: SwipeButton stuck if swiped halfway and scrolled vertically inside scrollview SwipeButton stuck if swiped halfway and scrolled vertically inside scrollview May 20, 2022
@2ducanhpham
Copy link

Same issue!

@akhilsanker
Copy link

Hi @CyberMew , any solutions?

Thanks

@2ducanhpham
Copy link

2ducanhpham commented Jul 18, 2023

I solved the problem with:

<ScrollView
bounces={false}
disableScrollViewPanResponder={true}
disableIntervalMomentum={true}

Library works very smoothly @akhilsanker @CyberMew @UdaySravanK

@UdaySravanK
Copy link
Owner

I solved the problem with:

<ScrollView
bounces={false}
disableScrollViewPanResponder={true}
disableIntervalMomentum={true}

Library works very smoothly @akhilsanker @CyberMew @UdaySravanK

Thanks @2ducanhpham. If you are sure about the fix, feel free to open a PR. I will test it when I get time and release the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

4 participants